Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VA-13359] Add Logger for raw provider API data #14139

Merged
merged 0 commits into from
Oct 13, 2023

Conversation

maxx1128
Copy link
Contributor

This pull request aims to make the raw response of PPMS training information available through the vets-api terminal instances on Argo CD. After discussing options in this Slack help request thread, adding this logger was found to be the best way to check if training data is being returned as part of provider data and how to make sure it's properly added to the vets-api response.

Summary

  • (Summarize the changes that have been made to the platform)
    • Making more PPMS data available to check for making it properly available to the API.
  • (Which team do you work for, does your team own the maintenance of this component?)
    • I'm with the Facilities team.

Related issue(s)

Relates to department-of-veterans-affairs/va.gov-cms#13359

Testing done

Confirmed with backend and facilities team that this data is okay to be included in a Rails logger in a terminal instance. It doesn't make any additional information visible that isn't already visible, and it's only made visible in terminal instances anyway.

Screenshots

Note: Optional

What areas of the site does it impact?

Facility Locator

Acceptance criteria

  • Facilities and Backend team have approved merging and then testing on integrated environment through Argo terminal instance
  • No error nor warning in the console.
  • All tests are passing
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@maxx1128 maxx1128 requested review from a team October 13, 2023 12:42
RachalCassity
RachalCassity previously approved these changes Oct 13, 2023
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array-3 branch from 18516e5 to cfa1615 Compare October 13, 2023 15:04
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array-3/main/main October 13, 2023 15:05 In progress
@eselkin eselkin self-requested a review October 13, 2023 17:36
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for terminal debugging to me.

@maxx1128 maxx1128 merged this pull request into master Oct 13, 2023
13 checks passed
@maxx1128 maxx1128 deleted the va-13359-ppms-trainings-array-3 branch October 13, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants