Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VA-13359: Add Trainings to PPMS facilities response #13213

Merged
merged 0 commits into from
Aug 1, 2023

Conversation

maxx1128
Copy link
Contributor

@maxx1128 maxx1128 commented Jul 10, 2023

This pull request aims to make the array of PPMS training information available through the vets-api endpoint on the front-end.

Summary

  • (Summarize the changes that have been made to the platform)
    • Making more PPMS data available on the front-end.
  • (Which team do you work for, does your team own the maintenance of this component?)
    • I'm with the Facilities team.

Related issue(s)

Relates to department-of-veterans-affairs/va.gov-cms#13359

Testing done

Confirmed with backend and facilities team that testing can be done on the staging environment after merging.

Screenshots

Note: Optional

What areas of the site does it impact?

Facility Locator

Acceptance criteria

  • Facilities and Backend team have approved merging and then testing on integrated environment through Argo terminal instance
  • No error nor warning in the console.
  • All tests are passing
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@maxx1128 maxx1128 requested a review from a team as a code owner July 10, 2023 19:23
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array-2/main/main July 10, 2023 19:23 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to va-13359-ppms-trainings-array-2/main/main July 10, 2023 19:38 Inactive
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array-2 branch from 9d6445d to 7b56458 Compare July 31, 2023 14:21
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array-2/main/main July 31, 2023 14:22 In progress
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array-2/main/main July 31, 2023 14:26 In progress
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array-2 branch from a44e2b9 to 4e3307d Compare July 31, 2023 14:52
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array-2/main/main July 31, 2023 14:53 In progress
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array-2 branch from 4e3307d to 6f312df Compare July 31, 2023 15:50
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array-2/main/main July 31, 2023 15:50 In progress
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array-2 branch from 6f312df to 8b5dcd4 Compare July 31, 2023 16:30
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array-2/main/main July 31, 2023 16:31 In progress
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array-2 branch 2 times, most recently from 2d03076 to 6897ecc Compare July 31, 2023 18:11
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array-2/main/main July 31, 2023 18:11 In progress
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array-2/main/main July 31, 2023 18:12 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to va-13359-ppms-trainings-array-2/main/main July 31, 2023 18:30 Inactive
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array-2 branch from 6897ecc to f7ca6ee Compare July 31, 2023 19:39
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array-2/main/main July 31, 2023 19:40 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to va-13359-ppms-trainings-array-2/main/main July 31, 2023 19:51 Inactive
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array-2 branch from f7ca6ee to cdf36cd Compare July 31, 2023 21:37
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array-2/main/main July 31, 2023 21:37 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to va-13359-ppms-trainings-array-2/main/main July 31, 2023 21:40 Inactive
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array-2 branch from cdf36cd to 4466fbc Compare July 31, 2023 21:47
Copy link

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is untestable, but looks free from defects.

Copy link
Contributor

@holdenhinkle holdenhinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxx1128 maxx1128 merged commit acebde8 into master Aug 1, 2023
@maxx1128 maxx1128 deleted the va-13359-ppms-trainings-array-2 branch August 1, 2023 15:46
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
* VA-13359: Add Trainings to PPMS facilities response

* va-13359: Add feature flag to PPMS array data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants