-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VA-13359: Add Trainings to PPMS facilities response #13213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vsp-bot
requested a deployment
to
va-13359-ppms-trainings-array-2/main/main
July 10, 2023 19:23
In progress
va-vfs-bot
temporarily deployed
to
va-13359-ppms-trainings-array-2/main/main
July 10, 2023 19:38
Inactive
maxx1128
force-pushed
the
va-13359-ppms-trainings-array-2
branch
from
July 31, 2023 14:21
9d6445d
to
7b56458
Compare
va-vsp-bot
requested a deployment
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 14:22
In progress
va-vsp-bot
requested a deployment
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 14:26
In progress
maxx1128
force-pushed
the
va-13359-ppms-trainings-array-2
branch
from
July 31, 2023 14:52
a44e2b9
to
4e3307d
Compare
va-vsp-bot
requested a deployment
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 14:53
In progress
maxx1128
force-pushed
the
va-13359-ppms-trainings-array-2
branch
from
July 31, 2023 15:50
4e3307d
to
6f312df
Compare
va-vsp-bot
requested a deployment
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 15:50
In progress
maxx1128
force-pushed
the
va-13359-ppms-trainings-array-2
branch
from
July 31, 2023 16:30
6f312df
to
8b5dcd4
Compare
va-vsp-bot
requested a deployment
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 16:31
In progress
maxx1128
force-pushed
the
va-13359-ppms-trainings-array-2
branch
2 times, most recently
from
July 31, 2023 18:11
2d03076
to
6897ecc
Compare
va-vsp-bot
requested a deployment
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 18:11
In progress
va-vsp-bot
requested a deployment
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 18:12
In progress
va-vfs-bot
temporarily deployed
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 18:30
Inactive
maxx1128
force-pushed
the
va-13359-ppms-trainings-array-2
branch
from
July 31, 2023 19:39
6897ecc
to
f7ca6ee
Compare
va-vsp-bot
requested a deployment
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 19:40
In progress
va-vfs-bot
temporarily deployed
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 19:51
Inactive
maxx1128
force-pushed
the
va-13359-ppms-trainings-array-2
branch
from
July 31, 2023 21:37
f7ca6ee
to
cdf36cd
Compare
va-vsp-bot
requested a deployment
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 21:37
In progress
va-vfs-bot
temporarily deployed
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 21:40
Inactive
maxx1128
force-pushed
the
va-13359-ppms-trainings-array-2
branch
from
July 31, 2023 21:47
cdf36cd
to
4466fbc
Compare
va-vsp-bot
requested a deployment
to
va-13359-ppms-trainings-array-2/main/main
July 31, 2023 21:48
In progress
swirtSJW
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is untestable, but looks free from defects.
holdenhinkle
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8 tasks
ryan-mcneil
pushed a commit
that referenced
this pull request
Dec 11, 2023
* VA-13359: Add Trainings to PPMS facilities response * va-13359: Add feature flag to PPMS array data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to make the array of PPMS training information available through the
vets-api
endpoint on the front-end.Summary
Related issue(s)
Relates to department-of-veterans-affairs/va.gov-cms#13359
Testing done
Confirmed with backend and facilities team that testing can be done on the staging environment after merging.
Screenshots
Note: Optional
What areas of the site does it impact?
Facility Locator
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?