Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VA-13359: Add Trainings to PPMS facilities response #12657

Closed
wants to merge 1 commit into from

Conversation

maxx1128
Copy link
Contributor

@maxx1128 maxx1128 commented May 15, 2023

This pull request aims to make the array of PPMS training information available through the vets-api endpoint on the front-end.

Summary

  • (Summarize the changes that have been made to the platform)
    • Making more PPMS data available on the front-end.
  • (Which team do you work for, does your team own the maintenance of this component?)
    • I'm with the Facilities team.

Related issue(s)

Closes department-of-veterans-affairs/va.gov-cms#13359

Testing done

Still working on it

Screenshots

Note: Optional

What areas of the site does it impact?

Facility Locator

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array/main/main May 15, 2023 17:34 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to va-13359-ppms-trainings-array/main/main May 15, 2023 18:34 Inactive
@maxx1128 maxx1128 marked this pull request as ready for review May 16, 2023 14:40
@maxx1128 maxx1128 requested a review from a team as a code owner May 16, 2023 14:40
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array/main/main May 16, 2023 15:20 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to va-13359-ppms-trainings-array/main/main May 16, 2023 15:21 Inactive
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array branch from a5af5b5 to d1e7b72 Compare May 16, 2023 15:32
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array/main/main May 16, 2023 15:32 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to va-13359-ppms-trainings-array/main/main May 16, 2023 15:50 Inactive
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array branch from d1e7b72 to 4be57b6 Compare May 16, 2023 17:33
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array/main/main May 16, 2023 17:34 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to va-13359-ppms-trainings-array/main/main May 16, 2023 17:36 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array/main/main May 17, 2023 15:44 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to va-13359-ppms-trainings-array/main/main May 17, 2023 15:44 Inactive
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array branch from 643aea3 to 8762ebf Compare May 18, 2023 15:34
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array/main/main May 18, 2023 15:35 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to va-13359-ppms-trainings-array/main/main May 18, 2023 15:45 Inactive
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array branch from 8762ebf to b227fee Compare May 18, 2023 16:42
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array/main/main May 18, 2023 16:43 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to va-13359-ppms-trainings-array/main/main May 18, 2023 16:46 Inactive
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array branch from b227fee to 4a18619 Compare May 24, 2023 12:46
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array/main/main May 24, 2023 12:46 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to va-13359-ppms-trainings-array/main/main May 24, 2023 12:47 Inactive
@maxx1128 maxx1128 force-pushed the va-13359-ppms-trainings-array branch from 4a18619 to 8cfea7e Compare May 24, 2023 12:53
@va-vsp-bot va-vsp-bot requested a deployment to va-13359-ppms-trainings-array/main/main May 24, 2023 12:53 In progress
@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 23, 2023
@github-actions
Copy link

This PR has been closed because it has had no activity for 37 days

@github-actions github-actions bot closed this Jun 30, 2023
@github-actions github-actions bot deleted the va-13359-ppms-trainings-array branch June 30, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the content of the PPMS trainings array available via vets-api
3 participants