Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SidekiqStatsJob #99587

Open
rmtolmach opened this issue Dec 20, 2024 · 0 comments · May be fixed by department-of-veterans-affairs/vets-api#19990
Open

Remove SidekiqStatsJob #99587

rmtolmach opened this issue Dec 20, 2024 · 0 comments · May be fixed by department-of-veterans-affairs/vets-api#19990
Assignees

Comments

@rmtolmach
Copy link
Contributor

Not veteran-facing. The job gathers metrics like processed, failed, and scheduled. It's also not called anywhere in the app. It could be called directly in the rails console by a developer. According to DD, it hasn't been called in any environment in the past 15 days.

What does the job do?
When run, it gathers high-level statistics about Sidekiq jobs. A Sidekiq job about Sidekiq jobs! I don't think this is ever run, though. Coverband shows that the code is not hit. We can access these same metrics other ways in Datadog. And we do. Our retry monitor uses sidekiq.retries and there are many other similar options:
Image

Is the job still needed?
I don't think so, no. I think it can be removed but I'd like to find out where this was removed as a cron job, to gather a bit more evidence. looking... This job was deleted in this commit when the jobs were getting moved from one file to another. If deleting it was intentional, that decision was not called out in the PR, so it's possible it was accidentally deleted. It used to run every minute. But either way, it's not needed anymore.

Does the job need exception handling added?
No

Any other modifications needed?
Delete the code.

@rmtolmach rmtolmach changed the title SidekiqStatsJob Remove SidekiqStatsJob Dec 20, 2024
@rmtolmach rmtolmach linked a pull request Dec 20, 2024 that will close this issue
1 task
@rmtolmach rmtolmach self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant