You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not veteran-facing. The job gathers metrics like processed, failed, and scheduled. It's also not called anywhere in the app. It could be called directly in the rails console by a developer. According to DD, it hasn't been called in any environment in the past 15 days.
What does the job do?
When run, it gathers high-level statistics about Sidekiq jobs. A Sidekiq job about Sidekiq jobs! I don't think this is ever run, though. Coverband shows that the code is not hit. We can access these same metrics other ways in Datadog. And we do. Our retry monitor uses sidekiq.retries and there are many other similar options:
Is the job still needed?
I don't think so, no. I think it can be removed but I'd like to find out where this was removed as a cron job, to gather a bit more evidence. looking... This job was deleted in this commit when the jobs were getting moved from one file to another. If deleting it was intentional, that decision was not called out in the PR, so it's possible it was accidentally deleted. It used to run every minute. But either way, it's not needed anymore.
Does the job need exception handling added?
No
Any other modifications needed?
Delete the code.
The text was updated successfully, but these errors were encountered:
Not veteran-facing. The job gathers metrics like processed, failed, and scheduled. It's also not called anywhere in the app. It could be called directly in the rails console by a developer. According to DD, it hasn't been called in any environment in the past 15 days.
What does the job do?
When run, it gathers high-level statistics about Sidekiq jobs. A Sidekiq job about Sidekiq jobs! I don't think this is ever run, though. Coverband shows that the code is not hit. We can access these same metrics other ways in Datadog. And we do. Our retry monitor uses
sidekiq.retries
and there are many other similar options:Is the job still needed?
I don't think so, no. I think it can be removed but I'd like to find out where this was removed as a cron job, to gather a bit more evidence. looking... This job was deleted in this commit when the jobs were getting moved from one file to another. If deleting it was intentional, that decision was not called out in the PR, so it's possible it was accidentally deleted. It used to run every minute. But either way, it's not needed anymore.
Does the job need exception handling added?
No
Any other modifications needed?
Delete the code.
The text was updated successfully, but these errors were encountered: