Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review exception handling for Platform-owned Sidekiq jobs [Part 2 of 2] #98414

Closed
9 tasks done
AshleyGuerrant opened this issue Dec 4, 2024 · 6 comments
Closed
9 tasks done
Assignees
Labels
2024 backend platform-product-team zero-silent-failures Work related to eliminating silent failures

Comments

@AshleyGuerrant
Copy link

AshleyGuerrant commented Dec 4, 2024

User Story

As a platform backend dev, I want to know that all of the Sidekiq jobs we own are functioning properly, so that the Platform is stable.

Issue Description

As a follow-up to the review of Sidekiq jobs done in #94632, we need to go a little deeper into the low-priority jobs to review them for error handling. Use the sidekiq-exception-handling-review board (filtered by owner-(team):Platform) and go through each of the jobs labeled Low and review the four listed in the Tasks section for the following:

  1. What does the job do?
  2. Is the job still needed?
  3. Answer the questions in the "Draft" for each job (where applicable).
  4. Does the job need exception handling added?
  5. Any other modifications needed?

Add findings to the Draft for each job and then move each into the "Assessment Review Complete" column. For any that need work done, click "Convert to issue" on the Draft and add our team label.

Tasks

  • Review the exception handling and answer the questions listed above in the Draft for each of the platform-owned jobs:
    • TestUserDashboard::DailyMaintenance
    • AccountLoginStatisticsJob
    • SidekiqStatsJob
    • TransactionalEmailAnalyticsJob
  • Convert to issue any that need more work done.

Success Metrics

Platform-owned Sidekiq jobs are audited for necessity and error handling. Tickets are created for future work.

Acceptance Criteria

  • The four jobs listed above have been reviewed and filled out in the Sidekiq board.
  • Any that need more work are converted to Issues.
  • Any that don't need more work are moved to the "Action Items/Review Completed" column.

Validation

Review the four jobs listed above on the Sidekiq board to determine whether the action taken for each was appropriate.

@AshleyGuerrant
Copy link
Author

Sprint note: This ticket was split off from this ticket because it was pointed at over a 5 and needed to be broken down into more manageable segments of work.

@rmtolmach
Copy link
Contributor

TestUserDashboard::DailyMaintenance - Moved to done column on sidekiq board. No action needed.

@rmtolmach
Copy link
Contributor

AccountLoginStatisticsJob - Done (on our end). After doing some investigation, I realized this belongs to Identity so I reassigned it.

@rmtolmach
Copy link
Contributor

SidekiqStatsJob - Almost done. I converted this to an issue for the job to get deleted at a later point. But then I realized actually deleting the code was less work than writing up the issue, so I have a PR to delete the job and the test: department-of-veterans-affairs/vets-api#19990.

I'll start on the last on on Monday!

@rmtolmach
Copy link
Contributor

TransactionalEmailAnalyticsJob - this is not owned by Platform. I reassigned the codeowner for this job in department-of-veterans-affairs/vets-api#20013.

@LindseySaari
Copy link
Contributor

This looks good! For the ones without action items completed, it appears @rmtolmach has reassigned to the appropriate teams!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024 backend platform-product-team zero-silent-failures Work related to eliminating silent failures
Projects
None yet
Development

No branches or pull requests

3 participants