Skip to content

Commit

Permalink
CODEOWNERS change and removing sentry calls in the job
Browse files Browse the repository at this point in the history
  • Loading branch information
micahaspyr committed Apr 16, 2024
1 parent 0fa6124 commit f4c9c4a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,6 @@ app/sidekiq/account_login_statistics_job.rb @department-of-veterans-affairs/octo
app/sidekiq/benefits_intake_status_job.rb @department-of-veterans-affairs/platform-va-product-forms @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/sidekiq/bgs @department-of-veterans-affairs/benefits-dependents-management @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/sidekiq/central_mail/delete_old_claims.rb @department-of-veterans-affairs/mbs-core-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/sidekiq/central_mail/submit_career_counseling_job.rb @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/sidekiq/central_mail/submit_form4142_job.rb @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/sidekiq/central_mail/submit_saved_claim_job.rb @department-of-veterans-affairs/backend-review-group
app/sidekiq/central_mail/submit_central_form686c_job.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/benefits-dependents-management
Expand Down Expand Up @@ -619,6 +618,7 @@ app/sidekiq/income_limits @department-of-veterans-affairs/vfs-public-websites-fr
app/sidekiq/in_progress_form_cleaner.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/sidekiq/kms_key_rotation @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/sidekiq/lighthouse @department-of-veterans-affairs/backend-review-group
app/sidekiq/lighthouse/submit_career_counseling_job.rb @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/sidekiq/mhv @department-of-veterans-affairs/vfs-mhv-medical-records @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/sidekiq/pager_duty @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
app/sidekiq/preneeds @department-of-veterans-affairs/mbs-core-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
Expand Down
9 changes: 3 additions & 6 deletions app/sidekiq/lighthouse/submit_career_counseling_job.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
module Lighthouse
class SubmitCareerCounselingJob
include Sidekiq::Job
include SentryLogging
RETRY = 14

STATSD_KEY_PREFIX = 'worker.lighthouse.submit_career_counseling_job'
Expand All @@ -23,11 +22,10 @@ def perform(claim_id, user_uuid = nil)
@claim.send_to_benefits_intake!
send_confirmation_email(user_uuid)
rescue => e

Check failure on line 24 in app/sidekiq/lighthouse/submit_career_counseling_job.rb

View workflow job for this annotation

GitHub Actions / Linting and Security

Lint/UselessAssignment: Useless assignment to variable - `e`.
log_message_to_sentry('SubmitCareerCounselingJob failed, retrying...', :warn,
generate_sentry_details(e))
Rails.logger.warn('SubmitCareerCounselingJob failed, retrying...')
raise
end
log_message_to_sentry('Successfully submitted form 25-8832', :info, { uuid: user_uuid })
Rails.logger.info("Successfully submitted form 25-8832 for uuid: #{user_uuid}")
end

def send_confirmation_email(user_uuid)
Expand All @@ -38,8 +36,7 @@ def send_confirmation_email(user_uuid)
end

if email.blank?
log_message_to_sentry('No email to send confirmation regarding submitted form 25-8832', :info,
{ uuid: user_uuid })
Rails.logger.info("No email to send confirmation regarding submitted form 25-8832 for uuid: #{user_uuid}")
return
end

Expand Down

0 comments on commit f4c9c4a

Please sign in to comment.