Merge branch 'master' into mobile-reason-code-merge

department-of-veterans-affairs · Sep 9, 2024 · ea678b8 · ea678b8
2 parents af60db8 + 9132853
commit ea678b8
Show file tree

Hide file tree

Showing 258 changed files with 9,723 additions and 8,432 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
diff --git a/.github/workflows/code_checks.yml b/.github/workflows/code_checks.yml
@@ -150,6 +150,7 @@ jobs:
         with:
           name: Coverage Report
           path: coverage
+          include-hidden-files: true
 
       - name: Upload Test Results
         uses: actions/upload-artifact@v4

diff --git a/.github/workflows/code_health_report.yml b/.github/workflows/code_health_report.yml
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -673,7 +673,7 @@ RSpec/NoExpectationExample:
     - 'modules/check_in/spec/request/v2/sessions_request_spec.rb'
     - 'modules/claims_api/spec/requests/v1/disability_compensation_request_spec.rb'
     - 'modules/claims_api/spec/sidekiq/poa_vbms_updater_spec.rb'
-    - 'modules/va_forms/spec/requests/metadata_request_spec.rb'
+    - 'modules/va_forms/spec/requests/metadata_spec.rb'
     - 'spec/config/initializers/staccato_spec.rb'
     - 'spec/controllers/application_controller_spec.rb'
     - 'spec/controllers/v0/profile/ch33_bank_accounts_controller_spec.rb'

diff --git a/Gemfile b/Gemfile
@@ -147,6 +147,7 @@ gem 'rubyzip'
 gem 'savon'
 gem 'sentry-ruby'
 gem 'shrine'
+gem 'sign_in_service'
 gem 'slack-notify'
 gem 'socksify'
 gem 'staccato'

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -243,14 +243,14 @@ GEM
     attr_extras (7.1.0)
     awesome_print (1.9.2)
     aws-eventstream (1.3.0)
-    aws-partitions (1.966.0)
-    aws-sdk-core (3.201.5)
+    aws-partitions (1.971.0)
+    aws-sdk-core (3.203.0)
       aws-eventstream (~> 1, >= 1.3.0)
       aws-partitions (~> 1, >= 1.651.0)
       aws-sigv4 (~> 1.9)
       jmespath (~> 1, >= 1.6.1)
-    aws-sdk-kms (1.88.0)
-      aws-sdk-core (~> 3, >= 3.201.0)
+    aws-sdk-kms (1.89.0)
+      aws-sdk-core (~> 3, >= 3.203.0)
       aws-sigv4 (~> 1.5)
     aws-sdk-s3 (1.159.0)
       aws-sdk-core (~> 3, >= 3.201.0)
@@ -857,8 +857,7 @@ GEM
       hashie (>= 1.2.0, < 6.0)
       jwt (>= 1.5.6)
     retriable (3.1.2)
-    rexml (3.3.6)
-      strscan
+    rexml (3.3.7)
     rgeo (3.0.1)
     rgeo-activerecord (7.0.1)
       activerecord (>= 5.0)
@@ -914,18 +913,17 @@ GEM
       actionpack (>= 5.2, < 8.0)
       railties (>= 5.2, < 8.0)
     rtesseract (3.1.3)
-    rubocop (1.65.1)
+    rubocop (1.66.1)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.4, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
+      rubocop-ast (>= 1.32.2, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.32.1)
+    rubocop-ast (1.32.2)
       parser (>= 3.3.1.0)
     rubocop-capybara (2.21.0)
       rubocop (~> 1.41)
@@ -989,6 +987,9 @@ GEM
       connection_pool (>= 2.3.0)
       rack (>= 2.2.4)
       redis-client (>= 0.19.0)
+    sign_in_service (0.4.0)
+      faraday (~> 2.7)
+      jwt (~> 2.8)
     signet (0.19.0)
       addressable (~> 2.8)
       faraday (>= 0.17.5, < 3.a)
@@ -1016,8 +1017,6 @@ GEM
     stringio (3.1.1)
     strong_migrations (2.0.0)
       activerecord (>= 6.1)
-    strscan (3.1.0)
-    strscan (3.1.0-java)
     super_diff (0.12.1)
       attr_extras (>= 6.2.4)
       diff-lcs
@@ -1272,6 +1271,7 @@ DEPENDENCIES
   sidekiq (~> 7.2.0)
   sidekiq-ent!
   sidekiq-pro!
+  sign_in_service
   simple_forms_api!
   simplecov
   slack-notify

diff --git a/app/controllers/v0/apidocs_controller.rb b/app/controllers/v0/apidocs_controller.rb
@@ -190,7 +190,6 @@ class ApidocsController < ApplicationController
       Swagger::Responses::UnprocessableEntityError,
       Swagger::Schemas::Address,
       Swagger::Schemas::Appeals::Requests,
-      Swagger::Schemas::Appeals::HigherLevelReview,
       Swagger::Schemas::Appeals::NoticeOfDisagreement,
       Swagger::Schemas::ContactUs::SuccessfulInquiryCreation,
       Swagger::Schemas::ContactUs::InquiriesList,

diff --git a/app/controllers/v0/higher_level_reviews/contestable_issues_controller.rb b/app/controllers/v0/higher_level_reviews/contestable_issues_controller.rb
diff --git a/app/controllers/v0/higher_level_reviews_controller.rb b/app/controllers/v0/higher_level_reviews_controller.rb
diff --git a/app/controllers/v0/my_va/submission_statuses_controller.rb b/app/controllers/v0/my_va/submission_statuses_controller.rb
@@ -10,7 +10,11 @@ class SubmissionStatusesController < ApplicationController
       before_action { authorize :lighthouse, :access? }
 
       def show
-        report = Forms::SubmissionStatuses::Report.new(@current_user.user_account)
+        report = Forms::SubmissionStatuses::Report.new(
+          user_account: @current_user.user_account,
+          allowed_forms:
+        )
+
         result = report.run
 
         render json: serializable_from(result).to_json, status: status_from(result)
@@ -24,6 +28,10 @@ def controller_enabled?
         end
       end
 
+      def allowed_forms
+        %w[20-10207 21-0845 21-0966 21-0972 21-10210 21-4142 21-4142a 21P-0847]
+      end
+
       def serializable_from(result)
         hash = SubmissionStatusSerializer.new(result.submission_statuses).serializable_hash
         hash[:errors] = result.errors

diff --git a/app/controllers/v0/notice_of_disagreements_controller.rb b/app/controllers/v0/notice_of_disagreements_controller.rb