Route update and removing history variable from service_history metho…

…d in the claims base controller

app/controllers/claims_base_controller.rb

@@ -15,7 +15,7 @@
 
 class ClaimsBaseController < ApplicationController
   skip_before_action(:authenticate)
-  before_action :load_user, only: :create
+  before_action :load_user, only: %i[create service_history]
 
   # Creates and validates an instance of the class, removing any copies of
   # the form that had been previously saved by the user.
@@ -44,14 +44,7 @@ def show
   end
 
   def service_history
-    history = if current_user.icn
-                service.get_service_history(current_user.icn)
-              else
-                # find the current user icn via querying an auth endpoint
-                { data: [], status: 401 }
-              end
-
-    render(json: history)
+    render(json: service.get_service_history(current_user.icn))
   end
 
   private
@@ -68,5 +61,4 @@ def service
     @service ||= VeteranVerification::Service.new
   end
 
-  def find_by_icn; end
 end

config/routes.rb

@@ -366,7 +366,6 @@
       get 'document_download/:id', action: 'document_download'
       post 'submit_coe_claim'
       post 'document_upload'
-      get 'service_history/:icn'
     end
 
     get 'terms_of_use_agreements/:version/latest', to: 'terms_of_use_agreements#latest'