Fix bug in HealthFacilitiesController#retrieve_patsr_approved_facilities

department-of-veterans-affairs · Dec 20, 2024 · da56634 · da56634
1 parent 2c86d78
commit da56634
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/modules/ask_va_api/app/controllers/ask_va_api/v0/health_facilities_controller.rb b/modules/ask_va_api/app/controllers/ask_va_api/v0/health_facilities_controller.rb
@@ -18,7 +18,7 @@ def search
           end
         end
 
-        patsr_approved_codes = retrieve_patsr_approved_facilities.pluck(:FacilityCode)
+        patsr_approved_codes = retrieve_patsr_approved_facilities[:Data].pluck(:FacilityCode)
 
         filtered_results = WillPaginate::Collection.create(
           api_results.current_page,
@@ -42,8 +42,7 @@ def show
       private
 
       def retrieve_patsr_approved_facilities
-        data = Crm::CacheData.new.fetch_and_cache_data(endpoint: 'Facilities', cache_key: 'Facilities', payload: {})
-        JSON.parse(data, symbolize_names: true)[:Data]
+        Crm::CacheData.new.fetch_and_cache_data(endpoint: 'Facilities', cache_key: 'Facilities', payload: {})
       end
 
       def api

diff --git a/modules/ask_va_api/spec/requests/ask_va_api/v0/health_facilities_spec.rb b/modules/ask_va_api/spec/requests/ask_va_api/v0/health_facilities_spec.rb
@@ -79,7 +79,8 @@
 
   let(:cache_data_instance) { Crm::CacheData.new }
   let(:patsr_facilities) do
-    File.read('modules/ask_va_api/config/locales/get_facilities_mock_data.json')
+    data = File.read('modules/ask_va_api/config/locales/get_facilities_mock_data.json')
+    JSON.parse(data, symbolize_names: true)
   end
 
   before do