Fixes cassette and call after refactor

department-of-veterans-affairs · Mar 26, 2024 · bcbc8da · bcbc8da
1 parent 651f501
commit bcbc8da
Show file tree

Hide file tree

Showing 3 changed files with 46 additions and 46 deletions.
diff --git a/modules/claims_api/lib/bgs_service/vnp_ptcpnt_service.rb b/modules/claims_api/lib/bgs_service/vnp_ptcpnt_service.rb
@@ -4,9 +4,9 @@ module ClaimsApi
   class VnpPtcpntService < ClaimsApi::LocalBGS
     # vnpPtcpntCreate - This service is used to create VONAPP participant information
     def vnp_ptcpnt_create(options)
-      convert_nil_values(options)
+      arg_strg = convert_nil_values(options)
       body = Nokogiri::XML::DocumentFragment.parse <<~EOXML
-        # {arg_strg}
+        #{arg_strg}
       EOXML
 
       make_request(endpoint: 'VnpPtcpntWebServiceBean/VnpPtcpntService', action: 'vnpPtcpntCreate', body:,
@@ -19,7 +19,7 @@ def convert_nil_values(options)
       arg_strg = '<arg0>'
       options.each do |option|
         arg = option[0].to_s.camelize(:lower)
-        arg_strg += (option[1].nil? ? "<#{arg} xsi:nil=true/>" : "<#{arg}>#{option[1]}</#{arg}>")
+        arg_strg += (option[1].nil? ? "<#{arg} xsi:nil='true'/>" : "<#{arg}>#{option[1]}</#{arg}>")
       end
       arg_strg += '</arg0>'
     end

diff --git a/modules/claims_api/spec/lib/claims_api/vnp_ptcpnt_service_spec.rb b/modules/claims_api/spec/lib/claims_api/vnp_ptcpnt_service_spec.rb
@@ -14,7 +14,7 @@
       options[:vnp_proc_id] = '3854437'
       options[:vnp_ptcpnt_id] = nil
       options[:fraud_ind] = nil
-      options[:jrn_dt] = Time.zone.now
+      options[:jrn_dt] = '2020-07-16T18:20:17Z'
       options[:jrn_lctn_id] = 281
       options[:jrn_obj_id] = 'VAgovAPI'
       options[:jrn_status_type_cd] = 'U'
@@ -30,7 +30,7 @@
       VCR.use_cassette('bgs/vnp_proc_service_v2/vnp_ptcpnt_service') do
         response = subject.vnp_ptcpnt_create(options)
         expect(response).to include(
-          { vnp_ptcpnt_id: '181911',
+          { vnp_ptcpnt_id: '181913',
             vnp_proc_id: '3854437',
             jrn_dt: '2020-07-16T18:20:17Z',
             jrn_lctn_id: '281',

diff --git a/spec/support/vcr_cassettes/bgs/vnp_proc_service_v2/vnp_ptcpnt_service.yml b/spec/support/vcr_cassettes/bgs/vnp_proc_service_v2/vnp_ptcpnt_service.yml