Skip to content

Commit

Permalink
MBMS-69224 Vets Api Updated vets-json-schema version (#19294)
Browse files Browse the repository at this point in the history
* MBMS-69224 Vets Api  Updated vets-json-schema version

* MBMS-69224 Fixing backend test failures

* MBMS-69224 Fixed preneed backend test

* MBMS-69224 Fixed another pre need backend test

* MBMS-68224 Removed unnecessary line from spec file

* Updated backend gemfile with new schema

* MBMS-69224 Fixed spec tests

* Updated vets-json-schema version

* Reverted Gemfile changes that dont pertain to vets-json-schema version

* Gemfile spacing issue
  • Loading branch information
ConnorJeff authored Nov 22, 2024
1 parent 9ff4ff7 commit b837dc2
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ GIT

GIT
remote: https://github.com/department-of-veterans-affairs/vets-json-schema
revision: 71c4501d45b75000818c88707c9c0ecd3dc86dc7
revision: d100b223e002a2a4eea12544a9b9d539b0d2242f
branch: master
specs:
vets_json_schema (24.5.2)
vets_json_schema (24.5.7)
multi_json (~> 1.0)
script_utils (= 0.0.4)

Expand Down
2 changes: 1 addition & 1 deletion config/form_profile_mappings/40-10007.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ application:
address: [contact_information, address]
dateOfBirth: [identity_information, date_of_birth]
name: [identity_information, full_name]
ssn: [identity_information, hyphenated_ssn]
ssn: [identity_information, ssn]
email: [contact_information, email]
phoneNumber: [contact_information, us_phone]
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@
[{ 'title' => 'Validation error',
'detail' => "The property '#/application/veteran/militaryStatus' of " \
'type null did not match the following type: string in ' \
'schema f7285ec8-ff50-51f5-b481-fc3d2ad5c1bc',
'schema 5e610c8c-e49f-54bb-8079-710b31a7928c',
'code' => '109',
'status' => '422' },
{ 'title' => 'Validation error',
'detail' => "The property '#/application/veteran/militaryStatus' " \
'value nil did not match one of the following values: A' \
', I, D, S, R, E, O, V, X in schema ' \
'f7285ec8-ff50-51f5-b481-fc3d2ad5c1bc',
'5e610c8c-e49f-54bb-8079-710b31a7928c',
'code' => '109',
'status' => '422' }] })
end
Expand Down
2 changes: 1 addition & 1 deletion spec/factories/preneeds/claimants.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
date_of_birth { '2001-01-31' }
desired_cemetery { '400' } # Alabama National VA Cemetery
relationship_to_vet { '1' } # self
ssn { '123-45-6789' }
ssn { '123456789' }
email { '[email protected]' }
phone_number { '1234567890' }

Expand Down
2 changes: 1 addition & 1 deletion spec/factories/preneeds/veterans.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
marital_status { 'Married' }
military_service_number { '123456789' }
place_of_birth { 'Brooklyn, NY' }
ssn { '123-45-6789' }
ssn { '123456789' }
va_claim_number { '23456789' }
military_status { 'A' }
race { attributes_for(:race) }
Expand Down
2 changes: 1 addition & 1 deletion spec/models/form_profile_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
'address' => address,
'dateOfBirth' => user.birth_date,
'name' => full_name,
'ssn' => FormIdentityInformation.new(ssn: user.ssn).hyphenated_ssn,
'ssn' => user.ssn,
'email' => user.pciu_email,
'phoneNumber' => us_phone
}
Expand Down

0 comments on commit b837dc2

Please sign in to comment.