do not check no for burial responsibility and plot expense responsibi…

…lity
department-of-veterans-affairs · Apr 15, 2024 · a923d64 · a923d64
1 parent 209b1d7
commit a923d64
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/lib/pdf_fill/forms/va21p530v2.rb b/lib/pdf_fill/forms/va21p530v2.rb
@@ -725,12 +725,10 @@ def merge_fields(_options = {})
         # special case: these fields were built as checkboxes instead of radios, so usual radio logic can't be used.
         burial_expense_responsibility = @form_data['burialExpenseResponsibility']
         @form_data['hasBurialExpenseResponsibility'] = burial_expense_responsibility ? 'On' : nil
-        @form_data['noBurialExpenseResponsibility'] = burial_expense_responsibility ? nil : 'On'
 
         # special case: these fields were built as checkboxes instead of radios, so usual radio logic can't be used.
         plot_expense_responsibility = @form_data['plotExpenseResponsibility']
         @form_data['hasPlotExpenseResponsibility'] = plot_expense_responsibility ? 'On' : nil
-        @form_data['noPlotExpenseResponsibility'] = plot_expense_responsibility ? nil : 'On'
 
         # special case: these fields were built as checkboxes instead of radios, so usual radio logic can't be used.
         process_option = @form_data['processOption']

diff --git a/spec/fixtures/pdf_fill/21P-530V2/merge_fields.json b/spec/fixtures/pdf_fill/21P-530V2/merge_fields.json
@@ -76,9 +76,7 @@
     "veteranSocialSecurityNumber3":{"first":"987", "second":"65", "third":"4322"},
     "hasTransportation":"YES",
     "hasBurialExpenseResponsibility":"On",
-    "noBurialExpenseResponsibility":null,
     "hasPlotExpenseResponsibility":"On",
-    "noPlotExpenseResponsibility":null,
     "hasProcessOption":null,
     "noProcessOption":"On",
     "hasConfirmation":"YES",

diff --git a/spec/lib/pdf_fill/forms/va21p530v2_spec.rb b/spec/lib/pdf_fill/forms/va21p530v2_spec.rb
@@ -145,12 +145,14 @@ def class_form_data
 
     it 'leaves benefit selections blank on pdf if unselected', run_at: '2024-03-21 00:00:00 EDT' do
       unselected_benefits_data = get_fixture('pdf_fill/21P-530V2/kitchen_sink').except(
-        'burialAllowance', 'plotAllowance', 'transportation'
+        'burialExpenseResponsibility', 'plotExpenseResponsibility', 'transportation'
       )
       expected_merge_data = get_fixture('pdf_fill/21P-530V2/merge_fields').except(
-        'burialAllowance', 'plotAllowance', 'transportation'
+        'burialExpenseResponsibility', 'plotExpenseResponsibility', 'transportation'
       )
       expected_merge_data['hasTransportation'] = nil
+      expected_merge_data['hasBurialExpenseResponsibility'] = nil
+      expected_merge_data['hasPlotExpenseResponsibility'] = nil
       expect(described_class.new(unselected_benefits_data).merge_fields.to_json).to eq(
         expected_merge_data.to_json
       )