More rubocop whining

department-of-veterans-affairs · Apr 23, 2024 · 934989f · 934989f
1 parent 791325e
commit 934989f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/app/controllers/claims_base_controller.rb b/app/controllers/claims_base_controller.rb
@@ -44,11 +44,12 @@ def show
   end
 
   def service_history
-    if current_user.icn
-      history = service.get_service_history(current_user.icn)
-    else
-      # find the current user icn via querying an auth endpoint
-    end
+    history = if current_user.icn
+                service.get_service_history(current_user.icn)
+              else
+                # find the current user icn via querying an auth endpoint
+                { data: [] }
+              end
 
     render(json: history)
   end

diff --git a/spec/controllers/v0/education_career_counseling_claims_controller_spec.rb b/spec/controllers/v0/education_career_counseling_claims_controller_spec.rb
@@ -63,7 +63,7 @@
     end
 
     context 'logged in user with icn' do
-      let(:icn) { '123498767V234859'}
+      let(:icn) { '123498767V234859' }
 
       it 'returns the service history' do
         VCR.use_cassette('lighthouse/veteran_verification/service_history/200_response') do