Skip to content

Commit

Permalink
Fix linting
Browse files Browse the repository at this point in the history
  • Loading branch information
jefftmarks committed Dec 30, 2024
1 parent 7fa2899 commit 89ab2d6
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 7 deletions.
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -1751,6 +1751,8 @@ spec/requests/v1/higher_level_reviews_spec.rb @department-of-veterans-affairs/b
spec/requests/v1/notice_of_disagreements_spec.rb @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/benefits-decision-reviews-be
spec/requests/v1/post911_gi_bill_status_spec.rb @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/requests/v1/supplemental_claims_spec.rb @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/benefits-decision-reviews-be
spec/requests/v1/gi/lcpe/exams_spec.rb @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/requests/v1/gi/lcpe/certifications_spec.rb @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
spec/requests/v2/higher_level_reviews_spec.rb @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/backend-review-group
spec/controllers/v1/decision_review_evidences_controller_spec.rb @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/backend-review-group
spec/requests/va_profile @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
Expand Down
8 changes: 4 additions & 4 deletions spec/lib/gi/lcpe/client_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@

describe GI::LCPE::Client do
let(:service) { GI::LCPE::Client.new }

describe '#get_licenses_and_certs_v1' do
it 'gets list of licenses and certifications' do
VCR.use_cassette('gi/lcpe/get_licenses_and_certs_v1') do
response = service.get_license_and_cert_details_v1({}).response
lacs = response.body[:lacs]
expect(lacs.class).to be(Array)
expect(lacs.first.keys).to match_array([:enriched_id, :name, :type])
expect(lacs.first.keys).to contain_exactly(%i[enriched_id name type])
end
end
end
Expand All @@ -24,7 +24,7 @@
response = service.get_license_and_cert_details_v1({ id: '1@f9822' }).response
lac = response.body[:lac]
expect(lac.class).to be(Hash)
expect(lac.keys).to match_array([:enriched_id, :name, :type, :tests, :institution])
expect(lac.keys).to contain_exactly(%i[enriched_id name type tests institution])
expect(lac[:tests].class).to be(Array)
expect(lac[:institution].class).to be(Hash)
end
Expand All @@ -38,7 +38,7 @@
exams = response.body[:exams]
expect(exams.class).to be(Array)
expect(exams.first.class).to be(Hash)
expect(exams.first.keys).to match_array([:enriched_id, :name, :tests, :institution])
expect(exams.first.keys).to contain_exactly(%i[enriched_id name tests institution])
expect(exams.first[:tests].class).to be(Array)
expect(exams.first[:institution].class).to be(Hash)
end
Expand Down
5 changes: 3 additions & 2 deletions spec/models/gids_redis_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@

context 'and the method belongs to `GI::LCPE::Client`' do
it 'delegates to `GI::LCPE::Client`' do
allow_any_instance_of(GI::LCPE::Client).to receive(:get_licenses_and_certifications_v1).and_return(gids_response)

allow_any_instance_of(GI::LCPE::Client).to(
receive(:get_licenses_and_certifications_v1).and_return(gids_response)
)
expect(subject.get_licenses_and_certifications_v1(scrubbed_params)).to eq(gids_response.body)
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/requests/v1/gi/lcpe/lacs_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
context 'Retrieves license and certification details for GI Bill Comparison Tool' do
it 'returns 200 response' do
VCR.use_cassette('gi/lcpe/get_license_and_cert_details_v1') do
get v1_gi_lcpe_lacs_url + '/1@f9822'
"#{get v1_gi_lcpe_lacs_url}/1@f9822"

Check failure on line 24 in spec/requests/v1/gi/lcpe/lacs_spec.rb

View workflow job for this annotation

GitHub Actions / Linting and Security

Lint/Void: Literal `"#{get v1_gi_lcpe_lacs_url}/1@f9822"` used in void context.
expect(response).to have_http_status(:ok)
expect(response).to match_response_schema('gi/lcpe/lac')
end
Expand Down

0 comments on commit 89ab2d6

Please sign in to comment.