Skip to content

Commit

Permalink
[API-43131] Validate 526 v1 disabilitiesʼ classification code end date (
Browse files Browse the repository at this point in the history 
#19868)

* validate v1 classification code end date

* add tests; fix spelling

* add index to error message

* brd → bgs
  • Loading branch information
@tycol7
tycol7 authored Jan 6, 2025
1 parent bc149a7 commit 7c38e39
Show file tree
Hide file tree
Showing 2 changed files with 105 additions and 50 deletions.
52 changes: 33 additions & 19 deletions ...les/claims_api/app/controllers/concerns/claims_api/disability_compensation_validations.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -411,30 +411,44 @@ def validate_form_526_disability_secondary_disabilities!
end

def validate_form_526_disability_classification_code!
return if (form_attributes['disabilities'].pluck('classificationCode') - [nil]).blank?
form_attributes['disabilities'].each_with_index do |disability, index|
classification_code = disability['classificationCode']
next if classification_code.nil? || classification_code.blank?

if bgs_classification_ids.include?(classification_code)
validate_form_526_disability_classification_code_end_date!(classification_code, index)
else
raise ::Common::Exceptions::InvalidFieldValue.new("disabilities.#{index}.classificationCode",
classification_code)
end
end
end

form_attributes['disabilities'].each do |disability|
next if disability['classificationCode'].blank?
next if bgs_classification_ids.include?(disability['classificationCode'])
def validate_form_526_disability_classification_code_end_date!(classification_code, index)
bgs_disability = contention_classification_type_code_list.find { |d| d[:clsfcn_id] == classification_code }
end_date = bgs_disability[:end_dt] if bgs_disability

raise ::Common::Exceptions::InvalidFieldValue.new('disabilities.classificationCode',
disability['classificationCode'])
end
return if end_date.nil?

return if Date.parse(end_date) >= Time.zone.today

raise ::Common::Exceptions::InvalidFieldValue.new("disabilities.#{index}.classificationCode", classification_code)
end

def contention_classification_type_code_list
@contention_classification_type_code_list ||= if Flipper.enabled?(:claims_api_526_validations_v1_local_bgs)
service = ClaimsApi::StandardDataService.new(
external_uid: Settings.bgs.external_uid,
external_key: Settings.bgs.external_key
)
service.get_contention_classification_type_code_list
else
bgs_service.data.get_contention_classification_type_code_list
end
end

def bgs_classification_ids
return @bgs_classification_ids if @bgs_classification_ids.present?

contention_classification_type_codes = if Flipper.enabled?(:claims_api_526_validations_v1_local_bgs)
contention_service = ClaimsApi::StandardDataService.new(
external_uid: Settings.bgs.external_uid,
external_key: Settings.bgs.external_key
)
contention_service.get_contention_classification_type_code_list
else
bgs_service.data.get_contention_classification_type_code_list
end
@bgs_classification_ids = contention_classification_type_codes.pluck(:clsfcn_id)
contention_classification_type_code_list.pluck(:clsfcn_id)
end

def validate_form_526_disability_approximate_begin_date!
Expand Down
103 changes: 72 additions & 31 deletions modules/claims_api/spec/requests/v1/forms/526_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@
end
end

context "when 'treatments[].center.country' is too long'" do
context "when 'treatments[].center.country' is too long" do
let(:treated_disability_names) { ['PTSD (post traumatic stress disorder)'] }

it 'returns a bad request' do
Expand Down Expand Up @@ -1286,7 +1286,7 @@ def obj.class
end

context 'when consumer is representative' do
it 'returns an unprocessible entity status' do
it 'returns an unprocessable entity status' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/brd/countries') do
post path, params: data, headers: headers.merge(auth_header)
Expand Down Expand Up @@ -1391,7 +1391,7 @@ def obj.class
stub_mpi(build(:mpi_profile, birls_id: nil, birth_date: '19560506'))
end

it 'returns an unprocessible entity status' do
it 'returns an unprocessable entity status' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/brd/countries') do
post path, params: data, headers: headers.merge(auth_header)
Expand All @@ -1407,7 +1407,7 @@ def obj.class
stub_mpi(build(:mpi_profile, birls_id: nil, birth_date: '19560506'))
end

it 'returns an unprocessible entity status' do
it 'returns an unprocessable entity status' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/brd/countries') do
VCR.use_cassette('claims_api/bgs/claims/claims') do
Expand Down Expand Up @@ -1992,7 +1992,7 @@ def obj.class
context "when 'amount' is below the minimum" do
let(:military_retired_payment_amount) { 0 }

it 'responds with an unprocessible entity' do
it 'responds with an unprocessable entity' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/brd/countries') do
json_data = JSON.parse data
Expand All @@ -2008,7 +2008,7 @@ def obj.class
context "when 'amount' is above the maximum" do
let(:military_retired_payment_amount) { 1_000_000 }

it 'responds with an unprocessible entity' do
it 'responds with an unprocessable entity' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/bgs/claims/claims') do
VCR.use_cassette('claims_api/brd/countries') do
Expand Down Expand Up @@ -2059,7 +2059,7 @@ def obj.class
}
end

it 'responds with an unprocessible entity' do
it 'responds with an unprocessable entity' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/brd/countries') do
json_data = JSON.parse data
Expand Down Expand Up @@ -2122,7 +2122,7 @@ def obj.class
context "when 'amount' is below the minimum" do
let(:separation_payment_amount) { 0 }

it 'responds with an unprocessible entity' do
it 'responds with an unprocessable entity' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/brd/countries') do
json_data = JSON.parse data
Expand All @@ -2138,7 +2138,7 @@ def obj.class
context "when 'amount' is above the maximum" do
let(:separation_payment_amount) { 1_000_000 }

it 'responds with an unprocessible entity' do
it 'responds with an unprocessable entity' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/bgs/claims/claims') do
VCR.use_cassette('claims_api/brd/countries') do
Expand Down Expand Up @@ -2272,7 +2272,7 @@ def obj.class
end
end

context "when 'disabilites.secondaryDisabilities.classificationCode' is invalid" do
context "when 'disabilities.secondaryDisabilities.classificationCode' is invalid" do
let(:classification_type_codes) { [{ clsfcn_id: '1111' }] }

[true, false].each do |flipped|
Expand Down Expand Up @@ -2318,7 +2318,7 @@ def obj.class
end
end

context "when 'disabilites.secondaryDisabilities.classificationCode' does not match name" do
context "when 'disabilities.secondaryDisabilities.classificationCode' does not match name" do
let(:classification_type_codes) { [{ clsfcn_id: '1111' }] }

[true, false].each do |flipped|
Expand Down Expand Up @@ -2364,7 +2364,7 @@ def obj.class
end
end

context "when 'disabilites.secondaryDisabilities.approximateBeginDate' is present" do
context "when 'disabilities.secondaryDisabilities.approximateBeginDate' is present" do
it 'raises an exception if date is invalid' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/brd/countries') do
Expand Down Expand Up @@ -2420,7 +2420,7 @@ def obj.class
end
end

context "when 'disabilites.secondaryDisabilities.classificationCode' is not present" do
context "when 'disabilities.secondaryDisabilities.classificationCode' is not present" do
it 'raises an exception if name is not valid structure' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/brd/countries') do
Expand Down Expand Up @@ -2477,24 +2477,24 @@ def obj.class
end
end

describe "'disabilites' validations" do
describe "'disabilities' validations" do
describe "'disabilities.classificationCode' validations" do
[true, false].each do |flipped|
context "when feature flag is #{flipped}" do
before do
allow(Flipper).to receive(:enabled?).with(:claims_api_526_validations_v1_local_bgs).and_return(flipped)
if flipped
expect_any_instance_of(ClaimsApi::StandardDataService)
allow_any_instance_of(ClaimsApi::StandardDataService)
.to receive(:get_contention_classification_type_code_list).and_return(classification_type_codes)
else
expect_any_instance_of(BGS::StandardDataService)
allow_any_instance_of(BGS::StandardDataService)
.to receive(:get_contention_classification_type_code_list).and_return(classification_type_codes)
end
end

let(:classification_type_codes) { [{ clsfcn_id: '1111' }] }
let(:classification_type_codes) { [{ clsfcn_id: '1111', end_dt: 1.year.from_now.iso8601 }] }

context "when 'disabilites.classificationCode' is valid" do
context "when 'disabilities.classificationCode' is valid and expires in the future" do
it 'returns a successful response' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/bgs/claims/claims') do
Expand All @@ -2517,11 +2517,52 @@ def obj.class
end
end

context "when 'disabilites.classificationCode' is invalid" do
context "when 'disabilities.classificationCode' is valid but expires in the past" do
before do
if Flipper.enabled?(:claims_api_526_validations_v1_local_bgs)
allow_any_instance_of(ClaimsApi::StandardDataService)
.to receive(:get_contention_classification_type_code_list)
.and_return([{
clsfcn_id: '1111',
end_dt: 1.year.ago.iso8601
}])
else
allow_any_instance_of(BGS::StandardDataService)
.to receive(:get_contention_classification_type_code_list)
.and_return([{
clsfcn_id: '1111',
end_dt: 1.year.ago.iso8601
}])
end
end

it 'responds with a bad request' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api_bgs/claims/claims') do
VCR.use_cassette('claims_api/brd/countries') do
json_data = JSON.parse data
params = json_data
disabilities = [
{
disabilityActionType: 'NEW',
name: 'PTSD (post traumatic stress disorder)',
classificationCode: '1111'
}
]
params['data']['attributes']['disabilities'] = disabilities
post path, params: params.to_json, headers: headers.merge(auth_header)
expect(response).to have_http_status(:bad_request)
end
end
end
end
end

context "when 'disabilities.classificationCode' is invalid" do
it 'responds with a bad request' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/brd/countries') do
VCR.use_cassette('claims_api/bgs/stadard_service_data') do
VCR.use_cassette('claims_api/bgs/standard_service_data') do
json_data = JSON.parse data
params = json_data
disabilities = [
Expand All @@ -2544,9 +2585,9 @@ def obj.class
end

describe "'disabilities.ratedDisabilityId' validations" do
context "when 'disabilites.disabilityActionType' equals 'INCREASE'" do
context "when 'disabilities.disabilityActionType' equals 'INCREASE'" do
context "and 'disabilities.ratedDisabilityId' is not provided" do
it 'returns an unprocessible entity status' do
it 'returns an unprocessable entity status' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/bgs/claims/claims') do
VCR.use_cassette('claims_api/brd/countries') do
Expand Down Expand Up @@ -2593,7 +2634,7 @@ def obj.class
end

context "and 'disabilities.diagnosticCode' is not provided" do
it 'returns an unprocessible entity status' do
it 'returns an unprocessable entity status' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/brd/countries') do
json_data = JSON.parse data
Expand All @@ -2614,10 +2655,10 @@ def obj.class
end
end

context "when 'disabilites.disabilityActionType' equals 'NONE'" do
context "and 'disabilites.secondaryDisabilities' is defined" do
context "and 'disabilites.diagnosticCode is not provided" do
it 'returns an unprocessible entity status' do
context "when 'disabilities.disabilityActionType' equals 'NONE'" do
context "and 'disabilities.secondaryDisabilities' is defined" do
context "and 'disabilities.diagnosticCode is not provided" do
it 'returns an unprocessable entity status' do
mock_acg(scopes) do |auth_header|
VCR.use_cassette('claims_api/bgs/claims/claims') do
VCR.use_cassette('claims_api/brd/countries') do
Expand Down Expand Up @@ -2648,7 +2689,7 @@ def obj.class
end
end

context "when 'disabilites.disabilityActionType' equals value other than 'INCREASE'" do
context "when 'disabilities.disabilityActionType' equals value other than 'INCREASE'" do
context "and 'disabilities.ratedDisabilityId' is not provided" do
it 'responds with a 200' do
mock_acg(scopes) do |auth_header|
Expand All @@ -2674,7 +2715,7 @@ def obj.class
end
end

describe "'disabilites.approximateBeginDate' validations" do
describe "'disabilities.approximateBeginDate' validations" do
let(:disabilities) do
[
{
Expand Down Expand Up @@ -2727,7 +2768,7 @@ def obj.class
end
end

describe "'disabilites.specialIssues' validations" do
describe "'disabilities.specialIssues' validations" do
let(:disabilities) do
[
{
Expand Down Expand Up @@ -2882,7 +2923,7 @@ def obj.class
end
end

context "when 'specialIssues' are provided for some 'disabilites'" do
context "when 'specialIssues' are provided for some 'disabilities'" do
let(:disabilities) do
[
{
Expand Down

0 comments on commit 7c38e39

Please sign in to comment.