EZR: Use hash instead of array for zsf tags

department-of-veterans-affairs · Jan 10, 2025 · 75e866d · 75e866d
1 parent 013b6c6
commit 75e866d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/app/sidekiq/hca/ezr_submission_job.rb b/app/sidekiq/hca/ezr_submission_job.rb
@@ -11,10 +11,10 @@ class EzrSubmissionJob
     FORM_ID = '10-10EZR'
     VALIDATION_ERROR = HCA::SOAPParser::ValidationError
     STATSD_KEY_PREFIX = 'api.1010ezr'
-    DD_ZSF_TAGS = [
-      'service:healthcare-application',
-      'function: 10-10EZR async form submission'
-    ].freeze
+    DD_ZSF_TAGS = {
+      service: 'healthcare-application',
+      function: '10-10EZR async form submission'
+    }.freeze
 
     # retry for  2d 1h 47m 12s
     # https://github.com/sidekiq/sidekiq/wiki/Error-Handling

diff --git a/spec/sidekiq/hca/ezr_submission_job_spec.rb b/spec/sidekiq/hca/ezr_submission_job_spec.rb
@@ -98,7 +98,6 @@ def expect_submission_failure_email_and_statsd_increments
           described_class.within_sidekiq_retries_exhausted_block(msg) do
             expect(VANotify::EmailJob).not_to receive(:perform_async)
             expect(StatsD).not_to receive(:increment).with('api.1010ezr.submission_failure_email_sent')
-            expect(StatsD).not_to receive(:increment).with('silent_failure_avoided_no_confirmation', tags:)
           end
         end
       end