BE | Ask va api Fix Inquiry bug and create FacilitiesDataJob (#19976)

* Created get_facilities_mock_data.json and update static_data.json

- get_facilties_mock_data.json is a list of PATSR approved health facilities
- static_data.json is now up to data with the most recent addition from CRM API

* Fix bug in InquiryDetails and update spec

- inquiry_details now handles `it's a general question` correctly

* Created FacilitiesDataJob

- Job will run every 24hours to cache the data

* Update HealthFacilities#search

- search now will filter and allow only patsr approved facilities

lib/periodic_jobs.rb

@@ -59,6 +59,9 @@
   # Update Optionset data cache
   mgr.register('0 0 * * *', 'Crm::OptionsetDataJob')
 
+  # Update Facilities data cache
+  mgr.register('0 0 * * *', 'Crm::FacilitiesDataJob')
+
   # Update FormSubmissionAttempt status from Lighthouse Benefits Intake API
   mgr.register('0 0 * * *', 'BenefitsIntakeStatusJob')
 

modules/ask_va_api/app/controllers/ask_va_api/v0/health_facilities_controller.rb

@@ -17,7 +17,20 @@ def search
             api_result.tmp_covid_online_scheduling = mobile_api_get_by_id(api_result.id)
           end
         end
-        render_json(serializer, lighthouse_params, api_results)
+
+        patsr_approved_codes = retrieve_patsr_approved_facilities.pluck(:FacilityCode)
+
+        filtered_results = WillPaginate::Collection.create(
+          api_results.current_page,
+          api_results.per_page,
+          api_results.total_entries
+        ) do |pager|
+          filtered_items = api_results.select { |object| patsr_approved_codes.include?(object.unique_id) }
+          pager.replace(filtered_items)
+          pager.total_entries = filtered_items.size
+        end
+
+        render_json(serializer, lighthouse_params, filtered_results)
       end
 
       def show
@@ -28,6 +41,11 @@ def show
 
       private
 
+      def retrieve_patsr_approved_facilities
+        data = Crm::CacheData.new.fetch_and_cache_data(endpoint: 'Facilities', cache_key: 'Facilities', payload: {})
+        JSON.parse(data, symbolize_names: true)[:Data]
+      end
+
       def api
         FacilitiesApi::V2::Lighthouse::Client.new
       end

modules/ask_va_api/app/lib/ask_va_api/inquiries/payload_builder/inquiry_details.rb

@@ -14,7 +14,8 @@ def call
           inquiry_details = base_inquiry_details(inquiry_params[:your_role])
 
           if education_benefits?(inquiry_params[:select_category],
-                                 inquiry_params[:select_topic])
+                                 inquiry_params[:select_topic]) ||
+             inquiry_params[:who_is_your_question_about] == "It's a general question"
             return general_inquiry(inquiry_params, inquiry_details)
           end
 

modules/ask_va_api/app/lib/ask_va_api/inquiries/payload_builder/shared_helpers.rb

@@ -20,7 +20,7 @@ def fetch_state(state_code)
         def formatted_pronouns(pronouns)
           return unless pronouns
 
-          pronouns[:pronouns_not_listed_text].presence || pronouns.key(true)&.to_s&.tr('_', '/')
+          pronouns[:pronouns_not_listed_text].presence || pronouns.key('true')&.to_s&.tr('_', '/')
         end
 
         def contact_field(field, inquiry_details, inquiry_params)

modules/ask_va_api/app/sidekiq/crm/facilities_data_job.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require 'sidekiq'
+
+module Crm
+  class FacilitiesDataJob
+    include Sidekiq::Job
+
+    # Schedule to run every 24 hours. Adjust as needed.
+    sidekiq_options retry: false, unique_for: 24.hours
+
+    def perform
+      Crm::CacheData.new.fetch_and_cache_data(endpoint: 'Facilities', cache_key: 'Facilities', payload: {})
+    rescue => e
+      log_error('optionset', e)
+    end
+
+    private
+
+    def log_error(action, exception)
+      LogService.new.call(action) do |span|
+        span.set_tag('error', true)
+        span.set_tag('error.msg', exception.message)
+      end
+      Rails.logger.error("Error during #{action}: #{exception.message}")
+    end
+  end
+end