Corrects the namespace in the create_veteran_representative method. R…

…e-records vcr cassettes, and adjusts the create_veteran_representative_request_spec accordingly.
department-of-veterans-affairs · Dec 20, 2024 · 4bc92fc · 4bc92fc
1 parent a84d15c
commit 4bc92fc
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 241 deletions.
diff --git a/modules/claims_api/lib/bgs_service/veteran_representative_service.rb b/modules/claims_api/lib/bgs_service/veteran_representative_service.rb
@@ -7,13 +7,12 @@ def bean_name
     end
 
     def create_veteran_representative(options)
-      # error VetRep cannot be null
       injected = convert_nil_values(options)
 
       body = Nokogiri::XML::DocumentFragment.parse <<~EOXML
-        <data:VetRepresentative>
+        <data:VeteranRepresentative>
           #{injected}
-        </data:VetRepresentative>
+        </data:VeteranRepresentative>
       EOXML
 
       make_request(
@@ -37,6 +36,7 @@ def read_all_veteran_representatives(type_code:, ptcpnt_id:)
           <formTypeCode>#{type_code}</formTypeCode>
         </ns0:CorpPtcpntIdFormTypeCode>
       EOXML
+
       ret = make_request(endpoint: bean_name, namespaces: { 'data' => '/data' },
                          action: 'readAllVeteranRepresentatives', body:,
                          key: 'VeteranRepresentativeReturnList',

diff --git a/...aims_api/bgs/veteran_representative_service/create_veteran_representative_request_spec.rb b/...aims_api/bgs/veteran_representative_service/create_veteran_representative_request_spec.rb
@@ -47,7 +47,7 @@
           'city' => 'Bridgeport',
           'claimantPtcpntId' => '182358',
           'claimantRelationship' => nil,
-          'formTypeCode' => '21-22',
+          'formTypeCode' => '21-22 ',
           'insuranceNumbers' => nil,
           'limitationAlcohol' => 'false',
           'limitationDrugAbuse' => 'false',
@@ -76,7 +76,7 @@
           'claimantMiddleName' => nil,
           'declinedBy' => nil,
           'declinedReason' => nil,
-          'secondaryStatus' => nil,
+          'secondaryStatus' => 'Obsolete',
           'veteranFirstName' => 'VERNON',
           'veteranLastName' => 'WAGNER',
           'veteranMiddleName' => nil,

diff --git a/modules/claims_api/spec/lib/claims_api/v2/disability_compensation_validation_spec.rb b/modules/claims_api/spec/lib/claims_api/v2/disability_compensation_validation_spec.rb
@@ -497,7 +497,7 @@ def current_error_array
         },
         'federalActivation' => {
           'activationDate' => '2023-10-01',
-          'anticipatedSeparationDate' => '2024-12-20'
+          'anticipatedSeparationDate' => '2028-12-20'
         }
       }
     end

diff --git a/...ims_api/bgs/veteran_representative_service/create_veteran_representative/valid_params.yml b/...ims_api/bgs/veteran_representative_service/create_veteran_representative/valid_params.yml