Bump rubocop from 1.68.0 to 1.69.0 (#19637)

* Bump rubocop from 1.68.0 to 1.69.0 Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.68.0 to 1.69.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.68.0...v1.69.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Rubocop name updates * New rubocop standards --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan Johnson <[email protected]> Co-authored-by: Ryan Johnson <[email protected]>
department-of-veterans-affairs · Dec 3, 2024 · 4ae0b35 · 4ae0b35
1 parent 5119455
commit 4ae0b35
Show file tree

Hide file tree

Showing 12 changed files with 9 additions and 18 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -736,7 +736,7 @@ GEM
     parallel (1.26.3)
     parallel_tests (4.7.2)
       parallel
-    parser (3.3.5.1)
+    parser (3.3.6.0)
       ast (~> 2.4.1)
       racc
     patience_diff (1.2.0)
@@ -937,17 +937,17 @@ GEM
       actionpack (>= 5.2, < 8.1)
       railties (>= 5.2, < 8.1)
     rtesseract (3.1.3)
-    rubocop (1.68.0)
+    rubocop (1.69.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.4, < 3.0)
-      rubocop-ast (>= 1.32.2, < 2.0)
+      rubocop-ast (>= 1.36.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.33.0)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.36.1)
       parser (>= 3.3.1.0)
     rubocop-capybara (2.21.0)
       rubocop (~> 1.41)

diff --git a/app/models/bgs_dependents/base.rb b/app/models/bgs_dependents/base.rb
@@ -34,7 +34,6 @@ def serialize_dependent_result(
       family_relationship_type,
       optional_fields = {}
     )
-
       {
         vnp_participant_id: participant[:vnp_ptcpnt_id],
         participant_relationship_type_name: participant_relationship_type,

diff --git a/lib/mpi/messages/add_person_implicit_search_message.rb b/lib/mpi/messages/add_person_implicit_search_message.rb
@@ -19,7 +19,6 @@ def initialize(first_name:,
                      address: nil,
                      idme_uuid: nil,
                      logingov_uuid: nil)
-
         @first_name = first_name
         @last_name = last_name
         @ssn = ssn

diff --git a/lib/mpi/messages/add_person_proxy_add_message.rb b/lib/mpi/messages/add_person_proxy_add_message.rb
@@ -17,7 +17,6 @@ def initialize(first_name:,
                      edipi:,
                      icn:,
                      search_token:)
-
         @first_name = first_name
         @last_name = last_name
         @ssn = ssn

diff --git a/lib/mpi/messages/update_profile_message.rb b/lib/mpi/messages/update_profile_message.rb
@@ -20,7 +20,6 @@ def initialize(first_name:,
                      idme_uuid: nil,
                      logingov_uuid: nil,
                      edipi: nil)
-
         @first_name = first_name
         @last_name = last_name
         @ssn = ssn

diff --git a/lib/sign_in/logingov/service.rb b/lib/sign_in/logingov/service.rb
@@ -32,7 +32,6 @@ def initialize(optional_scopes: [])
       def render_auth(state: SecureRandom.hex,
                       acr: Constants::Auth::LOGIN_GOV_IAL1,
                       operation: Constants::Auth::AUTHORIZE)
-
         Rails.logger.info('[SignIn][Logingov][Service] Rendering auth, ' \
                           "state: #{state}, acr: #{acr}, operation: #{operation}, " \
                           "optional_scopes: #{optional_scopes}")

diff --git a/...s/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb b/...s/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
@@ -1285,7 +1285,6 @@ def errors_array
 
       def collect_error_messages(detail: 'Missing or invalid attribute', source: '/',
                                  title: 'Unprocessable Entity', status: '422')
-
         errors_array.push({ detail:, source:, title:, status: })
       end
 

diff --git a/...laims_api/app/controllers/concerns/claims_api/v2/evidence_waiver_submission_validation.rb b/...laims_api/app/controllers/concerns/claims_api/v2/evidence_waiver_submission_validation.rb
@@ -31,7 +31,6 @@ def errors_array
 
       def collect_error_messages(detail: 'Missing or invalid attribute', source: '/',
                                  title: 'Unprocessable Entity', status: '422')
-
         errors_array.push({ detail:, source:, title:, status: })
       end
 

diff --git a/modules/claims_api/app/controllers/concerns/claims_api/v2/power_of_attorney_validation.rb b/modules/claims_api/app/controllers/concerns/claims_api/v2/power_of_attorney_validation.rb
@@ -171,7 +171,6 @@ def errors_array
 
       def collect_error_messages(detail: 'Missing or invalid attribute', source: '/',
                                  title: 'Unprocessable Entity', status: '422')
-
         errors_array.push({ detail:, source:, title:, status: })
       end
 

diff --git a/modules/claims_api/app/services/claims_api/document_service_base.rb b/modules/claims_api/app/services/claims_api/document_service_base.rb
@@ -9,7 +9,6 @@ class DocumentServiceBase < ServiceBase
     # rubocop:disable Metrics/ParameterLists
     def generate_upload_body(claim_id:, system_name:, doc_type:, pdf_path:, file_name:, birls_file_number:,
                              participant_id:, tracked_item_ids:)
-
       payload = {}
 
       data = build_body(claim_id:, system_name:, doc_type:, file_name:, participant_id:,

diff --git a/.../representation_management/lib/representation_management/v0/pdf_constructor/form_2122a.rb b/.../representation_management/lib/representation_management/v0/pdf_constructor/form_2122a.rb
@@ -186,7 +186,7 @@ def representative_contact_details(data)
           }
         end
 
-        # rubocop:disable Metrics/LineLength
+        # rubocop:disable Layout/LineLength
         # Disabled due to two extremely long keys.
         def appointment_options(data)
           {
@@ -208,7 +208,7 @@ def appointment_options(data)
             "#{PAGE2_KEY}.Provide_The_Names_Of_The_Individuals_Here[0]": data.consent_team_members&.to_sentence
           }
         end
-        # rubocop:enable Metrics/LineLength
+        # rubocop:enable Layout/LineLength
 
         def header_options(data)
           {

diff --git a/modules/vye/spec/controllers/vye/v1/verifications_controller_spec.rb b/modules/vye/spec/controllers/vye/v1/verifications_controller_spec.rb
@@ -52,9 +52,9 @@
     end
 
     it 'sets the cert_through date based on current date relative to award end dates' do
-      # rubocop:disable RSpec/ConstantDefinitionInBlock
+      # rubocop:disable Lint/ConstantDefinitionInBlock
       VerificationTest = Struct.new(:act_end)
-      # rubocop:enable RSpec/ConstantDefinitionInBlock
+      # rubocop:enable Lint/ConstantDefinitionInBlock
       award_dates = [
         Time.zone.parse('2024-08-10'),
         Time.zone.parse('2024-10-15'),
-Original file line number
+Diff line change
@@ Expand Up / @@ -1285,7 +1285,6 @@ def errors_array @@
           def collect_error_messages(detail: 'Missing or invalid attribute', source: '/',
                                      title: 'Unprocessable Entity', status: '422')
             errors_array.push({ detail:, source:, title:, status: })
           end
@@ Expand Down @@