fix rubocop errors

department-of-veterans-affairs · Nov 25, 2024 · 45e1f26 · 45e1f26
1 parent d7cf8eb
commit 45e1f26
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 13 deletions.
diff --git a/app/models/sign_in/session_container.rb b/app/models/sign_in/session_container.rb
@@ -22,7 +22,7 @@ class SessionContainer
       presence: true
     )
 
-    def initialize(session:, # rubocop:disable Metrics/ParameterLists
+    def initialize(session:,
                    refresh_token:,
                    access_token:,
                    anti_csrf_token:,

diff --git a/lib/lighthouse/auth/client_credentials/service.rb b/lib/lighthouse/auth/client_credentials/service.rb
@@ -18,7 +18,6 @@ class Service < Common::Client::Base
       # @param [String] aud_claim_url - The claim URL used as the 'aud' portion of the JWT
       # @param [String] rsa_key - RSA key used to encode the authentication JWT
       # @param [String] service_name - name to use when caching access token in Redis (Optional)
-      # rubocop:disable Metrics/ParameterLists
       def initialize(token_url, api_scopes, client_id, aud_claim_url, rsa_key, service_name = nil)
         @url = token_url
         @scopes = api_scopes
@@ -30,7 +29,6 @@ def initialize(token_url, api_scopes, client_id, aud_claim_url, rsa_key, service
         @tracker = AccessTokenTracker
         super()
       end
-      # rubocop:enable Metrics/ParameterLists
 
       ##
       # Request an access token

diff --git a/modules/claims_api/lib/bd/bd.rb b/modules/claims_api/lib/bd/bd.rb
@@ -37,7 +37,7 @@ def search(claim_id, file_number)
     # Upload document of mapped claim
     #
     # @return success or failure
-    def upload(claim:, pdf_path:, doc_type: 'L122', action: 'post', original_filename: nil, # rubocop:disable Metrics/ParameterLists
+    def upload(claim:, pdf_path:, doc_type: 'L122', action: 'post', original_filename: nil,
                pctpnt_vet_id: nil)
       unless File.exist? pdf_path
         ClaimsApi::Logger.log('benefits_documents', detail: "Error uploading doc to BD: #{pdf_path} doesn't exist,
@@ -120,7 +120,6 @@ def get_claim_id(doc_type, claim)
     # Generate form body to upload a document
     #
     # @return {parameters, file}
-    # rubocop:disable Metrics/ParameterLists
     def generate_upload_body(claim:, doc_type:, pdf_path:, action:, original_filename: nil,
                              pctpnt_vet_id: nil)
       payload = {}
@@ -151,7 +150,6 @@ def determine_birls_file_number(doc_type, auth_headers)
       end
       birls_file_num
     end
-    # rubocop:enable Metrics/ParameterLists
 
     def generate_file_name(doc_type:, veteran_name:, claim_id:, original_filename:, action:)
       # https://confluence.devops.va.gov/display/VAExternal/Document+Types

diff --git a/modules/claims_api/lib/bgs_service/local_bgs.rb b/modules/claims_api/lib/bgs_service/local_bgs.rb
@@ -278,7 +278,7 @@ def parsed_response(response, action:, key:, transform:)
       end
     end
 
-    def make_request(endpoint:, action:, body:, key: nil, namespaces: {}, transform_response: true) # rubocop:disable Metrics/MethodLength, Metrics/ParameterLists
+    def make_request(endpoint:, action:, body:, key: nil, namespaces: {}, transform_response: true) # rubocop:disable Metrics/MethodLength
       connection = log_duration event: 'establish_ssl_connection' do
         Faraday::Connection.new(ssl: { verify_mode: @ssl_verify_mode }) do |f|
           f.use :breakers

diff --git a/modules/vba_documents/lib/vba_documents/monthly_stats_generator.rb b/modules/vba_documents/lib/vba_documents/monthly_stats_generator.rb
@@ -58,7 +58,6 @@ def generate_summary_stats
       generate_consumer_stats(expired, errored, processing, success, vbms, all)
     end
 
-    # rubocop:disable Metrics/ParameterLists
     def generate_consumer_stats(expired, errored, processing, success, vbms, all)
       @stats['consumer_stats'] = []
 
@@ -78,7 +77,6 @@ def generate_consumer_stats(expired, errored, processing, success, vbms, all)
         }
       end
     end
-    # rubocop:enable Metrics/ParameterLists
 
     def generate_page_count_stats
       page_counts = records_in_date_range.where("uploaded_pdf->'total_pages' is not null")

diff --git a/modules/vye/spec/controllers/vye/v1/verifications_controller_spec.rb b/modules/vye/spec/controllers/vye/v1/verifications_controller_spec.rb
@@ -52,9 +52,9 @@
     end
 
     it 'sets the cert_through date based on current date relative to award end dates' do
-      # rubocop:disable RSpec/ConstantDefinitionInBlock
+      # rubocop:disable Lint/ConstantDefinitionInBlock
       VerificationTest = Struct.new(:act_end)
-      # rubocop:enable RSpec/ConstantDefinitionInBlock
+      # rubocop:enable Lint/ConstantDefinitionInBlock
       award_dates = [
         Time.zone.parse('2024-08-10'),
         Time.zone.parse('2024-10-15'),

diff --git a/spec/support/saml/response_builder.rb b/spec/support/saml/response_builder.rb
@@ -21,7 +21,6 @@ def create_user_identity(authn_context:, level_of_assurance:, attributes:, issue
       user.identity
     end
 
-    # rubocop:disable Metrics/ParameterLists
     def build_saml_response(
       authn_context:, level_of_assurance:,
       attributes: nil, issuer: nil, existing_attributes: nil, in_response_to: nil
@@ -58,7 +57,6 @@ def build_saml_response(
                                                in_response_to:)
       saml_response
     end
-    # rubocop:enable Metrics/ParameterLists
 
     def build_invalid_saml_response(in_response_to:, decrypted_document:, errors:, status_message:)
       saml_response = SAML::Responses::Login.new(decrypted_document.to_s)