remove unnecessary begins

department-of-veterans-affairs · Sep 9, 2024 · 3b37549 · 3b37549
1 parent 2ed14b7
commit 3b37549
Showing 1 changed file with 14 additions and 20 deletions.
diff --git a/app/controllers/concerns/form_attachment_create.rb b/app/controllers/concerns/form_attachment_create.rb
@@ -19,33 +19,27 @@ def serializer_klass
   end
 
   def validate_file_upload_class!
-    begin
-      # is it either ActionDispatch::Http::UploadedFile or Rack::Test::UploadedFile
-      unless filtered_params[:file_data].class.name.include? 'UploadedFile'
-        raise Common::Exceptions::InvalidFieldValue.new('file_data', filtered_params[:file_data].class.name)
-      end
-    rescue => e
-      log_exception_to_sentry(e, { context: 'FAC_validate', class: filtered_params[:file_data].class.name })
-      raise e
+    # is it either ActionDispatch::Http::UploadedFile or Rack::Test::UploadedFile
+    unless filtered_params[:file_data].class.name.include? 'UploadedFile'
+      raise Common::Exceptions::InvalidFieldValue.new('file_data', filtered_params[:file_data].class.name)
     end
+  rescue => e
+    log_exception_to_sentry(e, { context: 'FAC_validate', class: filtered_params[:file_data].class.name })
+    raise e
   end
 
   def save_attachment_to_cloud!
-    begin
-      form_attachment.set_file_data!(filtered_params[:file_data], filtered_params[:password])
-    rescue => e
-      log_exception_to_sentry(e, { context: 'FAC_cloud' })
-      raise e
-    end
+    form_attachment.set_file_data!(filtered_params[:file_data], filtered_params[:password])
+  rescue => e
+    log_exception_to_sentry(e, { context: 'FAC_cloud' })
+    raise e
   end
 
   def save_attachment_to_db!
-    begin
-      form_attachment.save!
-    rescue => e
-      log_exception_to_sentry(e, { context: 'FAC_db', errors: form_attachment.errors })
-      raise e
-    end
+    form_attachment.save!
+  rescue => e
+    log_exception_to_sentry(e, { context: 'FAC_db', errors: form_attachment.errors })
+    raise e
   end
 
   def form_attachment