updated update_documents_status_service, tests and moved test file to…

… the correct folder
department-of-veterans-affairs · Dec 11, 2024 · 31af3f8 · 31af3f8
1 parent 3777ecb
commit 31af3f8
Show file tree

Hide file tree

Showing 4 changed files with 82 additions and 233 deletions.
diff --git a/db/schema.rb b/db/schema.rb
diff --git a/lib/lighthouse/benefits_documents/update_documents_status_service.rb b/lib/lighthouse/benefits_documents/update_documents_status_service.rb
@@ -47,7 +47,6 @@ def initialize(benefits_document_uploads, lighthouse_status_response)
 
     def process_status_updates
       update_documents_status
-
       unknown_ids = @lighthouse_status_response.dig('data', 'requestIdsNotFound')
 
       return { success: true } if unknown_ids.blank?
@@ -82,9 +81,9 @@ def update_document_status(status_response)
       # end
     end
 
-    def statsd_document_base_key(statsd_document_type_key)
-      @statsd_document_base_key ||= "#{STATSD_BASE_KEY}.#{statsd_document_type_key}"
-    end
+    # def statsd_document_base_key(statsd_document_type_key)
+    #   @statsd_document_base_key ||= "#{STATSD_BASE_KEY}.#{statsd_document_type_key}"
+    # end
 
     # def log_failure(status_updater, document_upload)
     #   # Because Lighthouse's processing steps are subject to change, these metrics must be dynamic.

diff --git a/...ts/spec/lib/lighthouse/benefits_documents/form526/update_documents_status_service_spec.rb b/...ts/spec/lib/lighthouse/benefits_documents/form526/update_documents_status_service_spec.rb