Skip to content

Commit

Permalink
Merge branch 'API-33483-poa-v2-signatures' into API-33481-poa-v2-ind-…
Browse files Browse the repository at this point in the history 
…signatures
  • Loading branch information
@acovrig
acovrig committed Mar 26, 2024
2 parents b598216 + c739b49 commit 25df005
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 22 deletions.
70 changes: 48 additions & 22 deletions modules/claims_api/app/swagger/claims_api/v2/production/swagger.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9451,13 +9451,29 @@
"pointer": "data/attributes/serviceOrganization"
}
},
{
"title": "Unprocessable entity",
"detail": "The property /serviceOrganization did not contain the required key registrationNumber",
"status": "422",
"source": {
"pointer": "data/attributes/serviceOrganization"
}
},
{
"title": "Unprocessable entity",
"detail": "The property / did not contain the required key veteran",
"status": "422",
"source": {
"pointer": "data/attributes/"
}
},
{
"title": "Unprocessable entity",
"detail": "The property /serviceOrganization/withoutPoaCode is not defined on the schema. Additional properties are not allowed",
"status": "422",
"source": {
"pointer": "data/attributes/serviceOrganization/withoutPoaCode"
}
}
]
},
Expand Down Expand Up @@ -9515,7 +9531,7 @@
{
"title": "Resource not found",
"status": "404",
"detail": "Could not find an Organization with code: 083",
"detail": "Could not retrieve Power of Attorney with registration number: 67890 and poa code: 083",
"source": {
"pointer": "/modules/claims_api/app/controllers/claims_api/v2/veterans/power_of_attorney/organization_controller.rb:35:in `validate_org_poa_code!'"
}
Expand Down Expand Up @@ -9806,7 +9822,8 @@
"type": "object",
"additionalProperties": false,
"required": [
"poaCode"
"poaCode",
"registrationNumber"
],
"properties": {
"poaCode": {
Expand All @@ -9819,15 +9836,10 @@
"type": "string",
"example": "I help vets LLC."
},
"firstName": {
"description": "First Name of the representative.",
"type": "string",
"example": "John"
},
"lastName": {
"description": "Last Name of the representative",
"registrationNumber": {
"description": "Registration Number of representative.",
"type": "string",
"example": "Doe"
"example": "12345"
},
"jobTitle": {
"description": "Job title of the representative.",
Expand Down Expand Up @@ -9888,7 +9900,8 @@
}
},
"serviceOrganization": {
"poaCode": "083"
"poaCode": "083",
"registrationNumber": "67890"
}
}
}
Expand Down Expand Up @@ -10756,13 +10769,29 @@
"pointer": "data/attributes/serviceOrganization"
}
},
{
"title": "Unprocessable entity",
"detail": "The property /serviceOrganization did not contain the required key registrationNumber",
"status": "422",
"source": {
"pointer": "data/attributes/serviceOrganization"
}
},
{
"title": "Unprocessable entity",
"detail": "The property / did not contain the required key veteran",
"status": "422",
"source": {
"pointer": "data/attributes/"
}
},
{
"title": "Unprocessable entity",
"detail": "The property /serviceOrganization/withoutPoaCode is not defined on the schema. Additional properties are not allowed",
"status": "422",
"source": {
"pointer": "data/attributes/serviceOrganization/withoutPoaCode"
}
}
]
},
Expand Down Expand Up @@ -10820,7 +10849,7 @@
{
"title": "Resource not found",
"status": "404",
"detail": "Could not find an Organization with code: 083",
"detail": "Could not retrieve Power of Attorney with registration number: 67890 and poa code: 083",
"source": {
"pointer": "/modules/claims_api/app/controllers/claims_api/v2/veterans/power_of_attorney/organization_controller.rb:35:in `validate_org_poa_code!'"
}
Expand Down Expand Up @@ -11111,7 +11140,8 @@
"type": "object",
"additionalProperties": false,
"required": [
"poaCode"
"poaCode",
"registrationNumber"
],
"properties": {
"poaCode": {
Expand All @@ -11124,15 +11154,10 @@
"type": "string",
"example": "I help vets LLC."
},
"firstName": {
"description": "First Name of the representative.",
"type": "string",
"example": "John"
},
"lastName": {
"description": "Last Name of the representative",
"registrationNumber": {
"description": "Registration Number of representative.",
"type": "string",
"example": "Doe"
"example": "12345"
},
"jobTitle": {
"description": "Job title of the representative.",
Expand Down Expand Up @@ -11193,7 +11218,8 @@
}
},
"serviceOrganization": {
"poaCode": "083"
"poaCode": "083",
"registrationNumber": "67890"
}
}
}
Expand Down
8 changes: 8 additions & 0 deletions modules/claims_api/spec/sidekiq/v2/poa_form_builder_job_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@
'y' => 200
}
]
},
'serviceOrganization' => {
'firstName' => 'Bob',
'lastName' => 'Representative'
}
}
)
Expand Down Expand Up @@ -217,6 +221,10 @@
'y' => 200
}
]
},
'serviceOrganization' => {
'firstName' => 'Bob',
'lastName' => 'Representative'
}
}
)
Expand Down

0 comments on commit 25df005

Please sign in to comment.