[Automated] Merged master into target preview_envs_k8s

app/controllers/v0/pension_claims_controller.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'pension_21p527ez/tag_sentry'
+
 module V0
   class PensionClaimsController < ClaimsBaseController
     service_tag 'pension-application'
@@ -45,7 +47,7 @@ def show
     # Creates and validates an instance of the class, removing any copies of
     # the form that had been previously saved by the user.
     def create
-      PensionBurial::TagSentry.tag_sentry
+      Pension21p527ez::TagSentry.tag_sentry
 
       claim = claim_class.new(form: filtered_params[:form])
       user_uuid = current_user&.uuid

app/sidekiq/lighthouse/pension_benefit_intake_job.rb

@@ -3,6 +3,7 @@
 require 'benefits_intake_service/service'
 require 'central_mail/datestamp_pdf'
 require 'simple_forms_api_submission/metadata_validator'
+require 'pension_21p527ez/tag_sentry'
 
 module Lighthouse
   class PensionBenefitIntakeJob
@@ -33,6 +34,8 @@ class PensionBenefitIntakeError < StandardError; end
     # @param [Integer] saved_claim_id
     # rubocop:disable Metrics/MethodLength
     def perform(saved_claim_id)
+      Pension21p527ez::TagSentry.tag_sentry
+
       @saved_claim_id = saved_claim_id
       @claim = SavedClaim::Pension.find(saved_claim_id)
       raise PensionBenefitIntakeError, "Unable to find SavedClaim::Pension #{saved_claim_id}" unless @claim

lib/pension_21p527ez/tag_sentry.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Pension21p527ez
+  module TagSentry
+    module_function
+
+    TAG_NAME = 'pension_21p527ez'
+
+    def tag_sentry
+      Sentry.set_tags(feature: TAG_NAME)
+    end
+  end
+end

modules/claims_api/app/swagger/claims_api/description/v2.md

@@ -6,14 +6,11 @@ The Benefits Claims API Version 2 lets internal consumers:
 -   Automatically establish an Intent To File (21-0966) in VBMS
 -   Automatically establish a disability compensation claim (21-526EZ) in VBMS
 -   Digitally submit supporting documentation for disability compensation claims
--   Retrieve the active Power of Attorney for a Veteran
+-   Retrieve the active Power of Attorney organization of individual with power of attorney for a Veteran
+-   Automatically establish a power of attorney appointment in VBMS for an accredited organization (VA Form 21-22).
+-   Automatically establish a power of attorney appointment in VBMS for an accredited individual (VA Form 21-22a).
 
-Additional functionality will be added over time.
-
-You should use the [Benefits Claims API Version 1](https://developer.va.gov/explore/benefits/docs/claims?version=current) if: 
-
--   You are a consumer outside of VA and do not have the necessary VA agreements to use this API, and/or
--   You want automatic establishment of power of attorney (21-22 or 21-22a)
+You should use the [Benefits Claims API Version 1](https://developer.va.gov/explore/benefits/docs/claims?version=current) if you are a consumer outside of VA and do not have the necessary VA agreements to use this API.
 
 ## Technical Overview
 

modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json

@@ -3,7 +3,7 @@
   "info": {
     "title": "Benefits Claims",
     "version": "v2",
-    "description": "## Background\n\nThe Benefits Claims API Version 2 lets internal consumers: \n\n-   Retrieve existing claim information, including status, by claim ID\n-   Automatically establish an Intent To File (21-0966) in VBMS\n-   Automatically establish a disability compensation claim (21-526EZ) in VBMS\n-   Digitally submit supporting documentation for disability compensation claims\n-   Retrieve the active Power of Attorney for a Veteran\n\nAdditional functionality will be added over time.\n\nYou should use the [Benefits Claims API Version 1](https://developer.va.gov/explore/benefits/docs/claims?version=current) if: \n\n-   You are a consumer outside of VA and do not have the necessary VA agreements to use this API, and/or\n-   You want automatic establishment of power of attorney (21-22 or 21-22a)\n    \n## Technical Overview\n\nThis API accepts a payload of requests and responses with the payload identifying the claim and Veteran. Responses provide the submission’s processing status. Responses also provide a unique ID which can be used with the appropriate GET endpoint to return detailed, end-to-end claims status tracking. \n\nEnd-to-end claims tracking provides the status of claims as they move through the submission process, but does not return whether the claim was approved or denied. \n\n### Claim statuses\n\nClaims are first submitted by this API and then established in Veterans Benefits Management System (VBMS). A 200 response means that the claim was successfully submitted by the API. It does not mean VA has received the claim. Use the appropriate GET endpoint and the ID returned with your submission response to confirm the status of the submission. Statuses are:\n\n-   Pending - the claim is successfully submitted for processing\n-   Errored -  the submission encountered upstream errors\n-   Canceled -  the claim was identified as a duplicate or another issue caused the claim to be canceled. For duplicate claims,  the tracking of the claim's progress happens under a different Claim ID . \n\nOther statuses this API returns align with the [VA.gov](http://va.gov/) [claim status descriptions](https://www.va.gov/resources/what-your-claim-status-means/), which are:\n\n-   Claim received\n-   Initial review\n-   Evidence gathering, review, and decision\n-   Preparation for notification\n-   Complete\n\n### Finding a Veteran's unique VA ID\n\nThis API uses a unique Veteran identifier to identify the subject of each API request. This Veteran identifier can be retrieved by passing the Veteran’s first name, last name, DOB, and SSN to the ‘/veteran-id’ endpoint. This identifier should then be used as the Veteran ID parameter in request URLs.\n\nNote: though Veteran identifiers are typically static, they may change over time. If a specific Veteran ID suddenly responds with a ‘404 not found’ error, the identifier may have changed. It’s a good idea to periodically check the identifier for each Veteran.\n\n### Authentication and authorization\n\nThe authentication model for the Benefits Claims Version 2 is based on OAuth 2.0 / OpenID Connect and supports the [client credentials grant](https://developer.va.gov/explore/authorization/docs/client-credentials?api=claims).\n\n**Important**: To get production access, you must either work for VA or have specific VA agreements in place. If you have questions, [contact us](https://developer.va.gov/support/contact-us).\n\n### Test data for sandbox environment use\n\nWe use mock [test data in the sandbox environment](https://github.com/department-of-veterans-affairs/vets-api-clients/blob/master/test_accounts.md). Sandbox test data and test users for the Benefits Claims API are valid for all versions of the API.\n"
+    "description": "## Background\n\nThe Benefits Claims API Version 2 lets internal consumers: \n\n-   Retrieve existing claim information, including status, by claim ID\n-   Automatically establish an Intent To File (21-0966) in VBMS\n-   Automatically establish a disability compensation claim (21-526EZ) in VBMS\n-   Digitally submit supporting documentation for disability compensation claims\n-   Retrieve the active Power of Attorney organization of individual with power of attorney for a Veteran\n-   Automatically establish a power of attorney appointment in VBMS for an accredited organization (VA Form 21-22).\n-   Automatically establish a power of attorney appointment in VBMS for an accredited individual (VA Form 21-22a).\n\nYou should use the [Benefits Claims API Version 1](https://developer.va.gov/explore/benefits/docs/claims?version=current) if you are a consumer outside of VA and do not have the necessary VA agreements to use this API.\n    \n## Technical Overview\n\nThis API accepts a payload of requests and responses with the payload identifying the claim and Veteran. Responses provide the submission’s processing status. Responses also provide a unique ID which can be used with the appropriate GET endpoint to return detailed, end-to-end claims status tracking. \n\nEnd-to-end claims tracking provides the status of claims as they move through the submission process, but does not return whether the claim was approved or denied. \n\n### Claim statuses\n\nClaims are first submitted by this API and then established in Veterans Benefits Management System (VBMS). A 200 response means that the claim was successfully submitted by the API. It does not mean VA has received the claim. Use the appropriate GET endpoint and the ID returned with your submission response to confirm the status of the submission. Statuses are:\n\n-   Pending - the claim is successfully submitted for processing\n-   Errored -  the submission encountered upstream errors\n-   Canceled -  the claim was identified as a duplicate or another issue caused the claim to be canceled. For duplicate claims,  the tracking of the claim's progress happens under a different Claim ID . \n\nOther statuses this API returns align with the [VA.gov](http://va.gov/) [claim status descriptions](https://www.va.gov/resources/what-your-claim-status-means/), which are:\n\n-   Claim received\n-   Initial review\n-   Evidence gathering, review, and decision\n-   Preparation for notification\n-   Complete\n\n### Finding a Veteran's unique VA ID\n\nThis API uses a unique Veteran identifier to identify the subject of each API request. This Veteran identifier can be retrieved by passing the Veteran’s first name, last name, DOB, and SSN to the ‘/veteran-id’ endpoint. This identifier should then be used as the Veteran ID parameter in request URLs.\n\nNote: though Veteran identifiers are typically static, they may change over time. If a specific Veteran ID suddenly responds with a ‘404 not found’ error, the identifier may have changed. It’s a good idea to periodically check the identifier for each Veteran.\n\n### Authentication and authorization\n\nThe authentication model for the Benefits Claims Version 2 is based on OAuth 2.0 / OpenID Connect and supports the [client credentials grant](https://developer.va.gov/explore/authorization/docs/client-credentials?api=claims).\n\n**Important**: To get production access, you must either work for VA or have specific VA agreements in place. If you have questions, [contact us](https://developer.va.gov/support/contact-us).\n\n### Test data for sandbox environment use\n\nWe use mock [test data in the sandbox environment](https://github.com/department-of-veterans-affairs/vets-api-clients/blob/master/test_accounts.md). Sandbox test data and test users for the Benefits Claims API are valid for all versions of the API.\n"
   },
   "tags": [
     {
@@ -28,7 +28,7 @@
     },
     {
       "name": "Power of Attorney",
-      "description": "Allows authenticated and authorized users to retrieve the active power of attorney for a Veteran\n"
+      "description": "Allows authenticated and authorized users to automatically establish power of attorney appointments to an organization or an individual. Organizations and individuals must be VA accredited representatives.\n"
     }
   ],
   "components": {
@@ -5720,7 +5720,7 @@
               "application/json": {
                 "example": {
                   "data": {
-                    "id": "bb700978-5b4c-435d-b8ec-d16914ed3174",
+                    "id": "cf532e4e-e89e-4f9c-aebd-ce8361336a41",
                     "type": "forms/526",
                     "attributes": {
                       "veteran": {
@@ -7804,8 +7804,8 @@
                     "id": "1",
                     "type": "intent_to_file",
                     "attributes": {
-                      "creationDate": "2024-03-14",
-                      "expirationDate": "2025-03-14",
+                      "creationDate": "2024-03-26",
+                      "expirationDate": "2025-03-26",
                       "type": "compensation",
                       "status": "active"
                     }
@@ -8524,7 +8524,7 @@
                       "status": "422",
                       "detail": "Could not retrieve Power of Attorney due to multiple representatives with code: A1Q",
                       "source": {
-                        "pointer": "/modules/claims_api/app/controllers/claims_api/v2/veterans/power_of_attorney/base_controller.rb:111:in `representative'"
+                        "pointer": "/modules/claims_api/app/controllers/claims_api/v2/veterans/power_of_attorney/base_controller.rb:112:in `representative'"
                       }
                     }
                   ]
@@ -8623,7 +8623,7 @@
               "application/json": {
                 "example": {
                   "data": {
-                    "id": "3d2234a1-0151-4ddc-921f-7e3575089d6e",
+                    "id": "29b16b36-3108-411f-9f5f-2c1c2e147ea3",
                     "type": "individual",
                     "attributes": {
                       "code": "083",
@@ -9323,7 +9323,7 @@
               "application/json": {
                 "example": {
                   "data": {
-                    "id": "45bf00c5-36b3-4157-9620-6a89d5bd37ae",
+                    "id": "a7114d11-8ffd-4545-ad99-d70e74991e11",
                     "type": "organization",
                     "attributes": {
                       "code": "083",
@@ -11261,11 +11261,11 @@
               "application/json": {
                 "example": {
                   "data": {
-                    "id": "d3048cf3-3869-4c31-a873-996e4959b13a",
+                    "id": "7b0c58e1-4bf7-413c-a3ab-c8f6b95208b0",
                     "type": "claimsApiPowerOfAttorneys",
                     "attributes": {
                       "status": "submitted",
-                      "dateRequestAccepted": "2024-03-14",
+                      "dateRequestAccepted": "2024-03-26",
                       "representative": {
                         "serviceOrganization": {
                           "poaCode": "074"