Skip to content

Add error messaging to Veteran Verification /status endpoint #76246

Add error messaging to Veteran Verification /status endpoint

Add error messaging to Veteran Verification /status endpoint #76246

Triggered via pull request November 14, 2024 20:57
Status Failure
Total duration 11m 47s
Billable time 12m
Artifacts 2

code_checks.yml

on: pull_request
Publish Test Results and Coverage
31s
Publish Test Results and Coverage
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 5 warnings
Linting and Security: lib/lighthouse/veteran_verification/constants.rb#L1
Style/FrozenStringLiteralComment: Missing frozen string literal comment.
Linting and Security: lib/lighthouse/veteran_verification/constants.rb#L3
Style/MutableConstant: Freeze mutable objects assigned to constants.
Linting and Security: lib/lighthouse/veteran_verification/constants.rb#L5
Layout/LineEndStringConcatenationIndentation: Align parts of a string concatenated with backslash.
Linting and Security: lib/lighthouse/veteran_verification/constants.rb#L7
Layout/LineEndStringConcatenationIndentation: Align parts of a string concatenated with backslash.
Linting and Security: lib/lighthouse/veteran_verification/constants.rb#L9
Style/MutableConstant: Freeze mutable objects assigned to constants.
Linting and Security: lib/lighthouse/veteran_verification/constants.rb#L11
Layout/LineEndStringConcatenationIndentation: Align parts of a string concatenated with backslash.
Linting and Security: lib/lighthouse/veteran_verification/constants.rb#L13
Layout/LineEndStringConcatenationIndentation: Align parts of a string concatenated with backslash.
Linting and Security: lib/lighthouse/veteran_verification/constants.rb#L16
Layout/TrailingEmptyLines: Final newline missing.
Linting and Security: lib/lighthouse/veteran_verification/service.rb#L63
Rails/NegateInclude: Use `.exclude?` and remove the negation part.
Linting and Security: lib/lighthouse/veteran_verification/service.rb#L65
Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.
Test
Error: failed to remove labels: test-failure
Linting and Security
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-ecosystem/action-add-labels@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Linting and Security
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-ecosystem/action-add-labels@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-ecosystem/action-remove-labels@v1, actions-ecosystem/action-add-labels@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-ecosystem/action-remove-labels@v1, actions-ecosystem/action-add-labels@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test
failed to remove label: test-failure: HttpError: Label does not exist

Artifacts

Produced during runtime
Name Size
Coverage Report
6.11 MB
Test Results
636 KB