Remove SidekiqStatsJob #19990
Open
Remove SidekiqStatsJob #19990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: spec/sidekiq/sidekiq_stats_job_spec.rb |
github-actions
bot
added
ready-for-backend-review
and removed
codeowners-delete-failure
labels
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This job doesn't run anymore. We still get Sidekiq data and it is accessible in Datadog, but this job is not how it's generated. I'm removing it as part of department-of-veterans-affairs/va.gov-team#99587. See that issue for more detailed info.
Related issue(s)
Testing done
None.
Screenshots
Sidekiq metrics:
What areas of the site does it impact?
Sidekiq jobs. But really nothing, because this doesn't run anymore.
Acceptance criteria