VACMS-19805: Adds new statuses #19881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checking composer.lock changes... |
|
Checking composer.lock changes... |
…r facilities" This reverts commit 1f15486.
|
Checking composer.lock changes... |
github-actions
bot
added
the
Facilities
jv-agile6
previously approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Followed QA testing steps to a successful conclusion. Reviewed config changes and additions to field.field.node.vet_center_outstation.field_operating_status_facility.yml and field.storage.node.field_operating_status_facility.yml. No defects found. Approval granted
|
@omahane Followed QA steps and this is working as expected. I did notice that there are a few variations of the detail input field.
|
|
Checking composer.lock changes... |
|
Checking composer.lock changes... |
jv-agile6
previously approved these changes
Nov 19, 2024
|
Checking composer.lock changes... |
|
Accessibility Violations Found: [
{
"route": "/test-data-et",
"id": "button-name",
"impact": "critical",
"tags": [
"cat.name-role-value",
"wcag2a",
"wcag412",
"section508",
"section508.22.a",
"ACT",
"TTv5",
"TT6.a"
],
"description": "Ensures buttons have discernible text",
"help": "Buttons must have discernible text",
"helpUrl": "https://dequeuniversity.com/rules/axe/4.7/button-name?application=axeAPI",
"nodes": [
{
"any": [
{
"id": "button-has-visible-text",
"data": null,
"relatedNodes": [],
"impact": "critical",
"message": "Element does not have inner text that is visible to screen readers"
},
{
"id": "aria-label",
"data": null,
"relatedNodes": [],
"impact": "serious",
"message": "aria-label attribute does not exist or is empty"
},
{
"id": "aria-labelledby",
"data": null,
"relatedNodes": [],
"impact": "serious",
"message": "aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty"
},
{
"id": "non-empty-title",
"data": {
"messageKey": "noAttr"
},
"relatedNodes": [],
"impact": "serious",
"message": "Element has no title attribute"
},
{
"id": "presentational-role",
"data": null,
"relatedNodes": [],
"impact": "minor",
"message": "Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
}
],
"all": [],
"none": [],
"impact": "critical",
"html": "<button class=\"proofing-element-help\" role=\"tooltip\" data-proofing-help-title=\"About 'Page introduction' field\" data-proofing-help=\"Add an introduction that helps visitors understand if information on the page is relevant to them.\">
<span aria-hidden=\"true\">i</span>
</button>",
"target": [
".field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role=\"tooltip\"]"
],
"failureSummary": "Fix any of the following:
Element does not have inner text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
},
{
"any": [
{
"id": "button-has-visible-text",
"data": null,
"relatedNodes": [],
"impact": "critical",
"message": "Element does not have inner text that is visible to screen readers"
},
{
"id": "aria-label",
"data": null,
"relatedNodes": [],
"impact": "serious",
"message": "aria-label attribute does not exist or is empty"
},
{
"id": "aria-labelledby",
"data": null,
"relatedNodes": [],
"impact": "serious",
"message": "aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty"
},
{
"id": "non-empty-title",
"data": {
"messageKey": "noAttr"
},
"relatedNodes": [],
"impact": "serious",
"message": "Element has no title attribute"
},
{
"id": "presentational-role",
"data": null,
"relatedNodes": [],
"impact": "minor",
"message": "Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
}
],
"all": [],
"none": [],
"impact": "critical",
"html": "<button class=\"proofing-element-help\" role=\"tooltip\" data-proofing-help-title=\"About 'Generate a table of contents from major headings' field\" data-proofing-help=\"By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.\">",
"target": [
".field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role=\"tooltip\"]"
],
"failureSummary": "Fix any of the following:
Element does not have inner text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
},
{
"any": [
{
"id": "button-has-visible-text",
"data": null,
"relatedNodes": [],
"impact": "critical",
"message": "Element does not have inner text that is visible to screen readers"
},
{
"id": "aria-label",
"data": null,
"relatedNodes": [],
"impact": "serious",
"message": "aria-label attribute does not exist or is empty"
},
{
"id": "aria-labelledby",
"data": null,
"relatedNodes": [],
"impact": "serious",
"message": "aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty"
},
{
"id": "non-empty-title",
"data": {
"messageKey": "noAttr"
},
"relatedNodes": [],
"impact": "serious",
"message": "Element has no title attribute"
},
{
"id": "presentational-role",
"data": null,
"relatedNodes": [],
"impact": "minor",
"message": "Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
}
],
"all": [],
"none": [],
"impact": "critical",
"html": "<button class=\"proofing-element-help\" role=\"tooltip\" data-proofing-help-title=\"About 'Main content' field\" data-proofing-help=\"The main body of the page, which appears below the featured content.\">
<span aria-hidden=\"true\">i</span>
</button>",
"target": [
"button[data-proofing-help-title=\"About 'Main content' field\"]"
],
"failureSummary": "Fix any of the following:
Element does not have inner text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element's default semantics were not overridden with role=\"none\" or role=\"presentation\""
}
]
}
] |
jv-agile6
approved these changes
Nov 19, 2024
eselkin
reviewed
Nov 19, 2024
Comment on lines
7
to
16
| - node.type.vba_facility | ||
| - node.type.vet_center | ||
| module: | ||
| - tmgmt_content | ||
| third_party_settings: | ||
| tmgmt_content: | ||
| excluded: false | ||
| id: node.vba_facility.field_operating_status_more_info | ||
| id: node.vet_center.field_operating_status_more_info | ||
| field_name: field_operating_status_more_info | ||
| entity_type: node | ||
| bundle: vba_facility | ||
| bundle: vet_center |
There was a problem hiding this comment.
Curious about the vet_center settings in the vba file. Is that correct? I imagine it is, but just thought I'd double check.
There was a problem hiding this comment.
You're right. That was a copy/paste error. I caught it. Thanks, @eselkin
omahane
added a commit
that referenced
this pull request
Dec 18, 2024
* VACMS-19805: Adds new statuses * VACMS-19805: Brings Vet Center - Outstation in line with other facilities * Revert "VACMS-19805: Brings Vet Center - Outstation in line with other facilities" This reverts commit 1f15486. * VACMS-19805: Removes non-relevant change * VACMS-19805: Aligning more info label and help * VACMS-19805: Reverts changes to VBA * VACMS-19805: Updates operating status more info to match others. Co-authored-by: Christian Burk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #19805
Testing done
Manually
Screenshots
New statuses added
POST API Queue with a new status
QA steps
Confirm Operating Status changes with Vet Center - Outstation
Add the additional statuses to facilities
Check the POST API Queue
"operating_status":{"code":"TEMPORARY_CLOSURE""operating_status":{"code":"TEMPORARY_LOCATION""operating_status":{"code":"VIRTUAL_CARE""operating_status":{"code":"COMING_SOON"Check the Facilities Status Audit
Check VAMC System Operating Status IEF
"operating_status":{"code":"COMING_SOON"As admin, check all of the Facilities to make sure that they all behave the same way.
Select Team for PR review
CMS TeamPublic websitesFacilitiesUser supportAccelerated Publishing