-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-19512: Drupal UX for phone numbers #19607
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a37983c
Update staff profile & vamc b&i
davidmpickett 1043e7c
VAMC facility mental health
davidmpickett 8c8283e
fix truncated confirmation message
davidmpickett 5b5695e
reverting previous change & removing empty fieldset
davidmpickett eb6735e
finish reverting SCSS change
davidmpickett 4e13dfc
SCSS updates to phone number paragraph
davidmpickett 19fd66c
adding ids for specificity
davidmpickett 7e2a465
what about twig
davidmpickett 09aca30
Rolling back CSS and Twig. Adding fieldset wrapping
davidmpickett 2c0d74f
Merge branch 'main' into VACMS-19512
omahane 0035774
VACMS-19512: Updates SCSS for clarity and DS alignment
omahane 8d145ef
Merge branch 'main' into VACMS-19512
omahane b69f2ee
VACMS-19512: Updates test for phone widget
omahane 7691e7b
Merge branch 'main' into VACMS-19512
omahane 94010b2
Merge branch 'main' into VACMS-19512
omahane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,7 +90,7 @@ third_party_settings: | |
label: 'National top of page content' | ||
region: content | ||
parent_name: '' | ||
weight: 6 | ||
weight: 7 | ||
format_type: tooltip | ||
format_settings: | ||
show_label: '0' | ||
|
@@ -105,13 +105,12 @@ third_party_settings: | |
attributes: '' | ||
group_inquiries_about_copay: | ||
children: | ||
- field_phone_number | ||
- field_telephone | ||
- group_phone_number | ||
- field_office_hours | ||
label: 'For inquiries by phone about copay balance' | ||
region: content | ||
parent_name: '' | ||
weight: 5 | ||
weight: 6 | ||
format_type: details | ||
format_settings: | ||
classes: '' | ||
|
@@ -121,20 +120,6 @@ third_party_settings: | |
description: '' | ||
required_fields: false | ||
formatter: closed | ||
group_cashier_s_office: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Noting this change is expected as it resolves #16150 which is included in this PR. |
||
children: { } | ||
label: "Cashier's office" | ||
region: content | ||
parent_name: '' | ||
weight: 7 | ||
format_type: details | ||
format_settings: | ||
classes: '' | ||
show_empty_fields: true | ||
id: '' | ||
open: true | ||
description: '' | ||
required_fields: false | ||
group_national_above_top_of_page: | ||
children: | ||
- field_cc_above_top_of_page | ||
|
@@ -154,6 +139,23 @@ third_party_settings: | |
element: div | ||
label_element: h3 | ||
attributes: '' | ||
group_phone_number: | ||
children: | ||
- field_phone_number | ||
- field_telephone | ||
label: 'Phone number' | ||
region: content | ||
parent_name: group_inquiries_about_copay | ||
weight: 5 | ||
format_type: fieldset | ||
format_settings: | ||
classes: '' | ||
show_empty_fields: false | ||
id: '' | ||
label_as_html: false | ||
description: '' | ||
required_fields: true | ||
description_display: after | ||
id: node.vamc_system_billing_insurance.default | ||
targetEntityType: node | ||
bundle: vamc_system_billing_insurance | ||
|
@@ -235,39 +237,33 @@ content: | |
third_party_settings: { } | ||
field_office_hours: | ||
type: office_hours_default | ||
weight: 10 | ||
weight: 6 | ||
region: content | ||
settings: | ||
collapsed: false | ||
third_party_settings: { } | ||
field_phone_number: | ||
type: telephone_default | ||
weight: 8 | ||
weight: 10 | ||
region: content | ||
settings: | ||
placeholder: '' | ||
third_party_settings: { } | ||
field_telephone: | ||
type: paragraphs | ||
weight: 9 | ||
type: entity_reference_paragraphs | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added entity reference paragraph |
||
weight: 11 | ||
region: content | ||
settings: | ||
title: Paragraph | ||
title_plural: Paragraphs | ||
title: 'phone number' | ||
title_plural: 'phone numbers' | ||
edit_mode: open | ||
closed_mode: summary | ||
autocollapse: none | ||
closed_mode_threshold: 0 | ||
add_mode: dropdown | ||
add_mode: button | ||
form_display_mode: default | ||
default_paragraph_type: '' | ||
features: | ||
collapse_edit_all: collapse_edit_all | ||
duplicate: duplicate | ||
default_paragraph_type: phone_number | ||
third_party_settings: { } | ||
moderation_state: | ||
type: moderation_state_default | ||
weight: 7 | ||
weight: 12 | ||
region: content | ||
settings: { } | ||
third_party_settings: { } | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added entity reference paragraph