Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18805: Configurations for updating KB search. #19024

Conversation

JakeBapple
Copy link
Contributor

@JakeBapple JakeBapple commented Aug 22, 2024

Description

This work updates the configurations for the knowledge base search functionality.

Closes #18805.

Testing done

Local search testing with A/B results for different scenarios outlined in ticket #8136

QA steps

What needs to be checked to prove this works?
Search within the knowledge base for something you need.
What needs to be checked to prove it didn't break any related things?
Perform basic searches in knowledge base to make sure it is behaving as expected.
What variations of circumstances (users, actions, values) need to be checked?
Add in some of the stopwords located here to see if they populate the search results (they shouldn't).

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@JakeBapple JakeBapple requested a review from edmund-dunn August 22, 2024 18:09
@JakeBapple JakeBapple self-assigned this Aug 22, 2024
@JakeBapple JakeBapple linked an issue Aug 22, 2024 that may be closed by this pull request
2 tasks
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 22, 2024 18:10 Destroyed
Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This all looks good!

@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Aug 27, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 27, 2024 17:42 Destroyed
@JakeBapple JakeBapple merged commit 9c8c324 into main Aug 27, 2024
18 checks passed
@JakeBapple JakeBapple deleted the 18805-enable-indexing-and-tokenizing-processor-for-knowledge-base-search branch August 27, 2024 19:49
keisterj-oddball pushed a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Indexing and Tokenizing Processor for Knowledge Base Search
3 participants