Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18311: Limit Aging Content Email to Specific Users #18483

Merged
merged 9 commits into from
Jul 12, 2024

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Jul 9, 2024

Description

Relates to #18311

Adds both a comprehensive whitelist (allow_delivery_only_to) , and a blacklist (restrict_delivery_to), to recipient delivery access checks in Aging Content's custom message delivery Job Type. The lists accept any number of user id's for which to restrict/allow.

Testing done

Tested using a combination of white and blacklisted users.

Screenshots

Screenshot 2024-07-09 at 12 49 20 PM

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As a administrator

  1. Visit /admin/config/workflow/eca/aging_content_expired_fwb/edit
  2. Under 'Workflow options', check the 'Enabled' checkbox, and save the form
  3. Visit /admin/config/workflow/eca/aging_content_expired_fwb/action/create_advancedqueue_job/edit
  4. In the 'Payload', add these lines:
restrict_delivery_to:
  295
  1. Save the form
  2. Run cron
  3. Go to /admin/config/system/queues
  • Verify there is a job in the 'Queued' status
  1. Disable the ECA workflow (reverse of step 2 to disable the checkbox). This prevents queuing a duplicate message.
  2. Run cron
  3. Go to /admin/config/system/queues
  • Validate there is a job in the 'Failed' status with the message: Recipient is not on the allow list for message [xxx]
  1. Visit /admin/config/workflow/eca/aging_content_expired_fwb/action/create_advancedqueue_job/edit
  2. In the 'Payload', change the key 'restrict_delivery_to' to 'allow_delivery_only_to'.
  3. Save the form
  4. Perform step 2 (enable the workflow)
  5. Run cron
  6. Inverse step 2 (disable the workflow)
  7. Visit /admin/config/workflow/eca/aging_content_expired_fwb/action/create_advancedqueue_job/edit
  • Validate there is a job with the "success" status.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@dsasser dsasser requested review from a team as code owners July 9, 2024 19:51
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 9, 2024 19:51 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 11, 2024 19:18 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 11, 2024 19:22 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 11, 2024 20:25 Destroyed
Copy link
Contributor

@jv-agile6 jv-agile6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved

@dsasser dsasser merged commit eacfeb8 into main Jul 12, 2024
20 checks passed
@dsasser dsasser deleted the VACMS-18311-limit-aging-content-email-to-specific-users branch July 12, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants