Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17977: Updates the VBA-related code for launch #18414

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Jun 27, 2024

Description

Relates to #17977

Testing done

Manually

Screenshots

QA steps

Set up QA Content Publisher

  • As an admin, update the QA Content Publisher
    • Assign the following roles
      • Content creator - VBA
      • Content publisher
    • Assign the following Section
      • Albuquerque VA Regional Benefit Office

As QA Content Publisher, edit an unpublished VBA facility

  • Save as draft
  • In the most recent entry of the Post API queue, confirm that it the facility_url is a Facility Locator detail page link
  • Confirm that the log has a va_gov_content_release message stating that content release would not have been triggered
  • In the log entry, confirm that isFacility is true
  • In the log entry, confirm that the isPublished is false

As QA Content Publisher, edit a published VBA facility

  • Save as published
  • In the most recent entry of the Post API queue, confirm that it the facility_url is the Drupal-sourced VA.gov link
  • Confirm that the log has a va_gov_content_release message stating that content release would have been triggered
  • In the log entry, confirm that isFacility is true
  • In the log entry, confirm that the isPublished is true

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 27, 2024 17:59 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 27, 2024 17:59 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 27, 2024 18:06 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 27, 2024 18:06 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 27, 2024 18:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 27, 2024 18:48 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 27, 2024 18:53 Destroyed
@omahane omahane marked this pull request as ready for review June 27, 2024 19:43
@omahane omahane requested review from a team as code owners June 27, 2024 19:43
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 27, 2024 19:43 Destroyed
@omahane
Copy link
Contributor Author

omahane commented Jun 27, 2024

@ndouglas I know you're out of this side of the work, but I can't figure out why the phpunit test keeps failing on Tugboat. It passes locally.

PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

Testing /var/lib/tugboat/tests/phpunit
.....................................................S.........  63 / 301 ( 20%)
......................................................SSS...... 126 / 301 ( 41%)
............................................................... 189 / 301 ( 62%)
............................................................... 252 / 301 ( 83%)
.......F.........................................               301 / 301 (100%)

Time: 03:58.241, Memory: 3.01 GB

There was 1 failure:

1) tests\phpunit\va_gov_content_types\functional\Traits\IsFacilityTraitTest::testIsFacility with data set "vba_facility" ('vba_facility', false)
Failed asserting that true matches expected false.

/var/lib/tugboat/docroot/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:95
/var/lib/tugboat/tests/phpunit/va_gov_content_types/functional/Traits/IsFacilityTraitTest.php:30
/var/lib/tugboat/docroot/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
/var/lib/tugboat/docroot/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
/var/lib/tugboat/docroot/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
/var/lib/tugboat/docroot/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
/var/lib/tugboat/docroot/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/var/lib/tugboat/docroot/vendor/phpunit/phpunit/src/TextUI/Command.php:146
/var/lib/tugboat/docroot/vendor/phpunit/phpunit/src/TextUI/Command.php:99
/var/lib/tugboat/bin/phpunit:122

@omahane
Copy link
Contributor Author

omahane commented Jun 27, 2024

  1. tests\phpunit\va_gov_content_types\functional\Traits\IsFacilityTraitTest::testIsFacility with data set "vba_facility"

Figured it out. I had updated the unit test, but not the functional.

@omahane omahane force-pushed the VACMS-17977-add-vba-to-launched-facilities branch from 0bf0776 to cdba2c5 Compare June 27, 2024 20:18
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 27, 2024 20:18 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 27, 2024 20:18 Destroyed
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Jun 27, 2024
@omahane omahane enabled auto-merge (squash) June 28, 2024 02:38
@omahane omahane disabled auto-merge June 28, 2024 02:38
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 28, 2024 02:38 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 28, 2024 02:38 Destroyed
@omahane omahane enabled auto-merge (squash) June 28, 2024 15:44
@omahane omahane disabled auto-merge June 28, 2024 19:35
@omahane omahane enabled auto-merge (squash) July 1, 2024 15:18
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 1, 2024 15:18 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 1, 2024 15:18 Destroyed
@omahane omahane merged commit e430d1a into main Jul 1, 2024
19 checks passed
@omahane omahane deleted the VACMS-17977-add-vba-to-launched-facilities branch July 1, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants