Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18404: Updates content-build version #18406

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Jun 26, 2024

Description

Relates to #18404

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 26, 2024 17:16 Destroyed
@omahane omahane marked this pull request as ready for review June 26, 2024 17:19
Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@omahane omahane enabled auto-merge (squash) June 26, 2024 17:30
@omahane
Copy link
Contributor Author

omahane commented Jun 26, 2024

Got a PHPUnit error:

There was 1 error:

1) tests\phpunit\API\PostApiQueueTest::testPostApiQueueProcessing
Error: Call to a member function getStatusCode() on int

/var/lib/tugboat/tests/phpunit/API/PostApiQueueTest.php:93

which makes no sense.

I'm going to rebuild.

@dsasser
Copy link
Contributor

dsasser commented Jun 26, 2024

Got a PHPUnit error:

There was 1 error:

1) tests\phpunit\API\PostApiQueueTest::testPostApiQueueProcessing
Error: Call to a member function getStatusCode() on int

/var/lib/tugboat/tests/phpunit/API/PostApiQueueTest.php:93

which makes no sense.

I'm going to rebuild.

Yikes. Hard to trust the tests that are running on Tugboat at the moment, given its recent troubles.

@dsasser dsasser disabled auto-merge June 26, 2024 18:45
@timcosgrove timcosgrove merged commit 32d7fa5 into main Jun 26, 2024
19 of 20 checks passed
@timcosgrove timcosgrove deleted the VACMS-18404-update-content-build-v0.0.3536 branch June 26, 2024 18:47
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 23, 2024 18:48 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants