Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18309: Updated events api to basic auth. #18315

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

anantais
Copy link
Contributor

@anantais anantais commented Jun 12, 2024

Description

Closes #18309

Testing done

Verified that different authenticated (Drupal) users could view the json using an API Platform.

Screenshots

Screenshot 2024-06-12 at 5 15 57 PM

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Locally this can be tested using any Drupal user id with the default password and the Chrome plugin "Tabbed Postman"

  1. In the API platform go to Basic Auth.
  2. Enter the following url: https://va-gov-cms.ddev.site/all-events-data?_format=json
  3. Enter a Drupal username and the default password and click send or enter

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@anantais anantais linked an issue Jun 12, 2024 that may be closed by this pull request
1 task
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 12, 2024 21:16 Destroyed
@anantais anantais requested a review from JakeBapple June 12, 2024 21:17
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Jun 12, 2024
Copy link
Contributor

@JakeBapple JakeBapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@anantais anantais enabled auto-merge (squash) June 13, 2024 15:46
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 13, 2024 20:09 Destroyed
@anantais anantais merged commit 235f81b into main Jun 13, 2024
19 of 23 checks passed
@anantais anantais deleted the 18309-create-basic-auth-access-for-events-api branch June 13, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create basic auth access for Events API
3 participants