Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18064: Drupal Events json api for OPIA. #18210

Conversation

anantais
Copy link
Contributor

@anantais anantais commented May 23, 2024

Description

Closes #18064.

Testing done

Screenshots

QA steps

As user with admin access:

  1. Verify that the view exists by going to /admin/structure/views/view/events_data
  2. Verify that you can see the feed by going to /all-events-data
  3. The view is currently only accessible to admins so you can log in as non-admin user and you will not be able to see the feed.

Definition of Done

Feed is verified by an admin user.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@anantais anantais linked an issue May 23, 2024 that may be closed by this pull request
1 task
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 23, 2024 21:16 Destroyed
@anantais anantais requested a review from edmund-dunn May 23, 2024 21:17
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 23, 2024 21:20 Destroyed
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label May 23, 2024
Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the machine name for teh view to something meaningful like events_rest_api. We also need to make sure we include the query string for the format.

@anantais anantais force-pushed the 18064-create-query-for-drupal-events-data-as-json-file-to-opia-team branch from d261dcf to 923c9db Compare May 29, 2024 16:59
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 29, 2024 17:00 Destroyed
@anantais
Copy link
Contributor Author

anantais commented May 29, 2024

@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 29, 2024 18:39 Destroyed
@anantais
Copy link
Contributor Author

anantais commented May 29, 2024

The url for the api call is: /all-events-data?_format=json

@anantais anantais requested a review from edmund-dunn May 29, 2024 18:40
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 30, 2024 15:16 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 31, 2024 14:42 Destroyed
Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! This is good to go!

@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 31, 2024 17:47 Destroyed
@anantais anantais enabled auto-merge (squash) May 31, 2024 17:48
@anantais anantais merged commit ae35a0c into main May 31, 2024
19 checks passed
@anantais anantais deleted the 18064-create-query-for-drupal-events-data-as-json-file-to-opia-team branch May 31, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Query for Drupal Events Data as JSON file to OPIA Team
3 participants