Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-13214: Alphabetize all services and identify archived and draft services #17402

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Mar 4, 2024

Description

Relates to #13214

Testing done

Manually

Screenshots

Lovell Federal health care - TRICARE (with archived services)

Screenshot 2024-03-05 at 12 55 58 PM

Salt Lake City health care (with a draft service)

Screenshot 2024-03-05 at 12 57 43 PM

QA steps

Check a system with archived services

  • As QA Content Publisher, go to Lovelll federal health care - TRICARE
  • Confirm that the listing of health services is alphabetized
  • Confirm that archived services are labeled
  • Confirm that archived services are styled with the "unpublished pink"

Check a system with draft services

  • Go to Salt Lake City health care
  • Confirm that the listing of health services is alphabetized
  • Confirm that a draft service is labeled
  • Confirm that a draft service is styled with the "unpublished pink"

Check a system with neither archived nor draft facilities

  • Go to Kansas City health care
  • Confirm that the listing of health services is alphabetized
  • Confirm that a draft service is labeled
  • Confirm that a draft service is styled with the "unpublished pink"

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 4, 2024 20:30 Destroyed
@omahane omahane force-pushed the 13214-hide-archived-services-vamc branch from 6f60001 to 2513760 Compare March 4, 2024 20:35
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 4, 2024 20:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2024 15:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2024 16:06 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2024 17:52 Destroyed
@omahane omahane force-pushed the 13214-hide-archived-services-vamc branch from 44b8746 to 870ed8b Compare March 5, 2024 18:36
@omahane omahane force-pushed the 13214-hide-archived-services-vamc branch from 870ed8b to 26ddff2 Compare March 5, 2024 18:37
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 5, 2024 18:37 Destroyed
@omahane omahane force-pushed the 13214-hide-archived-services-vamc branch from 26ddff2 to 4cba0e2 Compare March 6, 2024 15:26
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 6, 2024 15:26 Destroyed
@omahane omahane changed the title VACMS-13214: Adds alter to view to alphabetize and remove archived. VACMS-13214: Adds alter to view to alphabetize and identify archived and draft services Mar 6, 2024
@omahane omahane marked this pull request as ready for review March 6, 2024 15:44
@omahane omahane requested a review from a team as a code owner March 6, 2024 15:44
@omahane omahane changed the title VACMS-13214: Adds alter to view to alphabetize and identify archived and draft services VACMS-13214: Alphabetize and identify archived and draft services Mar 6, 2024
@omahane omahane changed the title VACMS-13214: Alphabetize and identify archived and draft services VACMS-13214: Alphabetize all services and identify archived and draft services Mar 6, 2024
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Mar 6, 2024
Copy link
Contributor

@Becapa Becapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Nice job! QA steps check out for the most part (I think the last 2 steps were copied into that section by accident).

@omahane
Copy link
Contributor Author

omahane commented Mar 6, 2024

(I think the last 2 steps were copied into that section by accident).

You're right. That was an oversight on my part.

@omahane omahane enabled auto-merge (squash) March 6, 2024 16:58
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 6, 2024 16:58 Destroyed
@omahane omahane force-pushed the 13214-hide-archived-services-vamc branch from dbc1be7 to a12f77d Compare March 6, 2024 18:43
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 6, 2024 19:58 Destroyed
@omahane omahane merged commit a5fa5ff into main Mar 6, 2024
18 checks passed
@omahane omahane deleted the 13214-hide-archived-services-vamc branch March 6, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants