Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17325: Restore missing add buttons #17377

Closed
wants to merge 3 commits into from

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Feb 28, 2024

Description

Relates to #17325

Testing done

Manually

Screenshots

Screenshot 2024-02-28 at 2 15 14 PM

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Setting up the QA Content Publisher

  • Login as an admin
  • Go to the QA Content Publisher user
    • Set the role to "Content creator - VAMC" and "Content publisher"
    • Set the Section to "VA Boston health care"

Testing as the editor

Login as QA Content Publisher

  • Add a VAMC Facility Health Service

    • Click on the Contact info accordion
    • Confirm that the "Add new phone number" button is present
    • Confirm that the "Add new email address" is present
  • Edit a VAMC Facility Health Service

    • Click on the Contact info accordion
    • Confirm that the "Add new phone number" button is present
    • Confirm that the "Add new email address" is present
    • Click on the "Hours" accordion to test that no regression was introduced
    • Change the Monday hours to 8 am to 8 pm
    • Save the node
  • Login as an admin

    • Check the Post API Queue
    • Confirm that there's an entry for "Amputation care - West Roxbury VA Medical Center"
    • Do a page search for "monday":"08:00 a.m. to 08:00 p.m."
    • Confirm that you found that string

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@omahane omahane marked this pull request as ready for review February 28, 2024 21:23
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 28, 2024 21:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 28, 2024 21:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 28, 2024 21:33 Destroyed
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Feb 28, 2024
@omahane
Copy link
Contributor Author

omahane commented Feb 29, 2024

@edmund-dunn It looks like the maintainer has added a fix for a new release that will be out in a couple days. I'm going to text his fix now to make sure it works for us in anticipation of the 1.17.0 release.

@omahane
Copy link
Contributor Author

omahane commented Mar 1, 2024

I tested the maintainers fix successfully: #17325 (comment)

@omahane omahane closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants