Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-14136: Editors should not be able to rename VAMC facility services. #17348

Merged

Conversation

Becapa
Copy link
Contributor

@Becapa Becapa commented Feb 27, 2024

Description

Relates to #14136.

Testing done

Cypress tests created as well as manual testing

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user QA Content Editor

  1. Edit a VAMC Facility Health Service node (e.g. 'Pharmacy - Orlando VA Medical Center' /node/22635/edit)
    • Expand the Health service and facility basic info section.
    • Verify that the Facility and VAMC system health service dropdowns are disabled.

As an administrator

  1. Edit a VAMC Facility Health Service node (you can use the same example as above)
    • Expand the Health service and facility basic info section.
    • Verify that the Facility and VAMC system health service dropdowns are not disabled.
  2. Edit a Vet Center - Facility Service node (e.g. Jackson Vet Center - Workshops and classes' /node/44823/edit)
    • Verify that Vet Center and Service name dropdowns are not disabled.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@Becapa Becapa requested a review from a team as a code owner February 27, 2024 15:17
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 27, 2024 15:17 Destroyed
@Becapa Becapa requested a review from omahane February 27, 2024 15:47
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Feb 27, 2024
@omahane
Copy link
Contributor

omahane commented Feb 27, 2024

Tested with QA Content Publisher, too.

Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chef's kiss. I like how you also brought Vet Center - Facility Service in line with VAMC so that admins can do all the things.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 27, 2024 19:05 Destroyed
@Becapa Becapa merged commit d1393f1 into main Feb 27, 2024
18 checks passed
@Becapa Becapa deleted the VACMS-14136-editors-shouldnt-rename-vamc-facility-services branch February 27, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants