Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17177: Shows descriptions for vet center services on node view/edit #17267

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

Becapa
Copy link
Contributor

@Becapa Becapa commented Feb 16, 2024

Description

Relates to #17177.

Testing done

Manual testing

Screenshots

Screenshot 2024-02-16 at 4 23 06 PM Screenshot 2024-02-16 at 4 22 50 PM

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As the QA Vet Center Editor user

  1. Edit a vet center facility service node (i.e. /node/36809/edit)
    • Validate that a 'General service description' field is visible, but not editable, making note of text in the 'Service description:'.
  2. Then click on the view tab for that node.
    • Validate that below the service name it shows the same content from the 'Service description:' from the previous step.
  3. Then edit the Vet Center itself (for the above example: /node/3771/edit)
    • Under the 'Services' section find the service from above (i.e. 'Whole health') and click 'Edit'
    • Validate that the 'General service description' is still visible.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@Becapa Becapa requested a review from a team as a code owner February 16, 2024 21:43
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 16, 2024 21:43 Destroyed
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very clean and easy to read.

I had one very minor suggestion.

|| ($event->getDisplay()->getOriginalMode() !== 'full')) {
return;
}
$build = &$event->getBuild();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question (for my own edification): Why does this need to be called via reference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that the reason for this is because we are making changes to the build. If we didn't call it by reference, then we'd just be getting a copy of the build and any changes we make to it below (line 178) wouldn't be reflected in the actual build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 27, 2024 14:53 Destroyed
@Becapa Becapa requested a review from omahane February 27, 2024 15:24
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go! Nice work.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 27, 2024 15:32 Destroyed
@Becapa Becapa enabled auto-merge (squash) February 27, 2024 15:33
@Becapa Becapa merged commit 924c3ee into main Feb 27, 2024
18 checks passed
@Becapa Becapa deleted the VACMS-17177-vet-center-service-description branch February 27, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants