Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17142: Update service content types post-Service Location migration #17225

Merged

Conversation

Becapa
Copy link
Contributor

@Becapa Becapa commented Feb 13, 2024

Description

Relates to #17142

Testing done

Manual

Screenshots

Screenshot 2024-02-13 at 1 24 31 PM Screenshot 2024-02-13 at 1 40 53 PM

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As a user with administrative access

  1. Go to add a VAMC Facility Health Service node (/node/add/health_care_local_health_service) and verify the following fields are not visible:
    • Appointment intro text
    • Appointment lead-in text
    • Are walkins accepted?
    • Is online scheduling available for this service?
    • Phone numbers for appointments
  2. Edit a Service Region page (i.e. /node/61786/edit)
    • Add some content to the service location section (Office visits, virtual support, appointment intro text, custom text, ust the facility phone number, other phone numbers, is online scheduling available)
    • Make note of the order of the fields on the page and save the page.
    • Click on the view tab and verify that the order of the page is the same as the edit tab.
  3. Edit a VAMC Facility Health Service page
    • Make note of the order of the fields on the page
    • Click on the view tab and verify that the order of the page is the same as the edit tab.
  4. Edit a VAMC Facility Non-clinical Service page
    • Make note of the order of the fields on the page
    • Click on the view tab and verify that the order of the page is the same as the edit tab.
  5. Edit a VBA Facility Health Service page
    • You may first need to generate a page by filling in all of the required fields and saving.
    • Make note of the order of the fields on the page
    • Click on the view tab and verify that the order of the page is the same as the edit tab.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@Becapa Becapa requested a review from a team as a code owner February 13, 2024 18:46
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 13, 2024 18:46 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 13, 2024 18:57 Destroyed
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks promising, but we need to also account for the service location fields and their display.

Office Visits, Virtual support and Appointments order

Screenshot 2024-02-13 at 2 25 25 PM

Appointments (detailed order)

Screenshot 2024-02-13 at 2 39 31 PM

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 13, 2024 22:06 Destroyed
@swirtSJW swirtSJW force-pushed the integration-service-location branch from ad1c1e7 to fa2f54b Compare February 14, 2024 03:36
@Becapa Becapa requested a review from a team as a code owner February 14, 2024 03:36
@Becapa Becapa requested a review from omahane February 14, 2024 14:06
@Becapa Becapa force-pushed the VACMS-17142-update-service-content-types branch from 7b2e496 to 6f200ff Compare February 14, 2024 14:42
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 14, 2024 14:42 Destroyed
@omahane omahane removed the request for review from a team February 14, 2024 15:28
Copy link
Contributor

@omahane omahane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, all present and correct.
Screenshot 2024-02-14 at 1 48 49 PM

@Becapa Becapa merged commit d80b0f4 into integration-service-location Feb 15, 2024
26 checks passed
@Becapa Becapa deleted the VACMS-17142-update-service-content-types branch February 15, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants