-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-16853: next build branches ftw #17154
Conversation
@@ -126,6 +126,7 @@ | |||
$settings['va_gov_web_root'] = '/var/www/cms/web'; | |||
$settings['va_gov_app_root'] = '/var/www/cms'; | |||
$settings['va_gov_vets_website_root'] = '/var/www/cms/docroot/vendor/va-gov/vets-website'; | |||
$settings['va_gov_next_build_root'] = '../next'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason this is relative vs the rest of the roots above? /var/www/cms/next
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason, just I knew that next was one directory above the docroot. I thought the right location for next was /var/www/html/next
in ddev, but I could have gotten the wrong place if the repo is included other places. I don't see /var/www/cms
locally, just /var/www/html/web
which is a symlink to docroot/vendor/va-gov/content-build
. But since this is a default settings file, I'm not sure these values carry through other overrides. They do get overriden in other settings files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if they get overridden elsewhere i'm not too worried about it. /var/www/cms/
may even be leftover from when the project used lando before ddev. it just stuck out to me because it was noticeably different format than the lines above.
docroot/modules/custom/va_gov_content_release/va_gov_content_release.module
Show resolved
Hide resolved
docroot/modules/custom/va_gov_content_release/src/Form/NextGitForm.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Tanner Heffner <[email protected]>
Co-authored-by: Tanner Heffner <[email protected]>
Co-authored-by: Tanner Heffner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, nice and clean!!
This reverts commit 828acc9.
This reverts commit 828acc9.
This reverts commit dfc8eec.
Description
closes #16853
Testing done
Screenshots
Content release form when you can trigger a build.
Content release form when build is running with a link to the build log.
QA steps
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing