Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16469: Updates widget to radio buttons #17132

Merged

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Feb 2, 2024

Description

Relates to #16469

Testing done

Manually

Screenshots

QA steps

Note: The steps include a full test of editing a NCA as as admin and adding and editing a VBA Facility as an editor. The other tests are lighter confirmations but should suffice, given that it is the same field on all tested content types.

Prepare the editor user

  • Assign QA Content Publisher to the following roles:
    • Content creator - VAMC
    • Content creator - VBA
    • Content creator - Vet Center
    • Content publisher
  • Assign QA Content Publisher to the following sections:
    • Cheyenne VA Regional Benefit Office
    • VA Boston health care
    • Oklahoma City Vet Center
    • Fargo Vet Center

NCA

As an admin, do the following:

  • Add a node
    • Click on "Normal services and hours" under Operating status
    • Confirm that the Operating status - more info element is not visible
    • Click on "Facility notice" under Operating status
    • Confirm that the Operating status - more info element is visible
    • Click on "Limited services and hours" under Operating status
    • Confirm that the Operating status - more info element is visible
    • Click on "Facility closed" under Operating status
    • Confirm that the Operating status - more info element is visible
  • Edit the Fort McClellan Post Cemetery
    • Click on "Normal services and hours" under Operating status
    • Confirm that the Operating status - more info element is not visible
    • Click on "Facility notice" under Operating status
    • Add text to Operating status - more info
    • Save the node
    • Edit the node
    • Confirm that the Operating status - more info element is visible
    • Confirm that the text you added is present
    • Click on "Limited services and hours" under Operating status
    • Confirm that the Operating status - more info element is visible
    • Click on "Facility closed" under Operating status
    • Confirm that the Operating status - more info element is visible
    • Click on "Normal services and hours" under Operating status
    • Confirm that the Operating status - more info element is not visible
    • Save the node
    • Edit the node
    • Click on "Limited services and hours" under Operating status
    • Confirm that the Operating status - more info element is visible
    • Confirm that the text you entered before is now gone

VBA Facility

As QA Content Publisher, do the following:

  • Edit the VA Regional Benefit Satellite Office at Sheridan VA Medical Center
    • Click on "Normal services and hours" under Operating status
    • Confirm that the Operating status - more info element is not visible
    • Click on "Facility notice" under Operating status
    • Add text to Operating status - more info
    • Save the node
    • Edit the node
    • Confirm that the Operating status - more info element is visible
    • Confirm that the text you added is present
    • Click on "Limited services and hours" under Operating status
    • Confirm that the Operating status - more info element is visible
    • Click on "Facility closed" under Operating status
    • Confirm that the Operating status - more info element is visible
    • Click on "Normal services and hours" under Operating status
    • Confirm that the Operating status - more info element is not visible
    • Save the node
    • Edit the node
    • Click on "Limited services and hours" under Operating status
    • Confirm that the Operating status - more info element is visible
    • Confirm that the text you entered before is now gone

Vet Center CAP

As QA Content Publisher, do the following:

  • Add a node
    • Click on "Normal services and hours" under Operating status
    • Confirm that the Operating status - more info element is not visible
    • Click on "Facility notice" under Operating status
    • Confirm that the Operating status - more info element is visible
    • Add text to Operating status - more info
    • Click on "Limited services and hours" under Operating status
    • Confirm that the Operating status - more info element is visible
    • Click on "Facility closed" under Operating status
    • Confirm that the Operating status - more info element is visible

What needs to be checked to prove it didn't break any related things?

VAMC Facility

As QA Content Publisher, do the following:

  • Edit the Jamaica Plain VA Medical Center
    • Click on "Normal services and hours" under Operating status
    • Confirm that the Operating status - more info element is not visible
    • Click on "Facility notice" under Operating status
    • Confirm that the Operating status - more info element is visible
    • Add text to Operating status - more info
    • Click on "Limited services and hours" under Operating status
    • Confirm that the Operating status - more info element is visible
    • Click on "Facility closed" under Operating status
    • Confirm that the Operating status - more info element is visible

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@omahane omahane requested a review from a team as a code owner February 2, 2024 17:14
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 2, 2024 17:14 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 2, 2024 17:54 Destroyed
eselkin
eselkin previously approved these changes Feb 2, 2024
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The YAML looks correct. I'm not sure what the changes do exactly.

@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Feb 2, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 2, 2024 19:11 Destroyed
Copy link
Contributor

@Becapa Becapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selects have turned into radios. The (updated) QA Tests pass and config looks good. I approve.

@omahane omahane enabled auto-merge (squash) February 2, 2024 21:23
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 2, 2024 21:24 Destroyed
@omahane omahane merged commit bf01488 into main Feb 2, 2024
18 checks passed
@omahane omahane deleted the VACMS-16469-change-operating-status-widget-hide-more-info branch February 2, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants