VACMS-000 Save test #16993
VACMS-000 Save test #16993
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
PHP_CodeSniffer
docroot/modules/custom/va_gov_facilities/va_gov_facilities.post_update.php|122 col 3| Line indented incorrectly; expected 0 spaces, found 2
docroot/modules/custom/va_gov_facilities/va_gov_facilities.post_update.php|124 col 1| Missing function doc comment
docroot/modules/custom/va_gov_facilities/va_gov_facilities.post_update.php|128 col 5| Inline comments must start with a capital letter
docroot/modules/custom/va_gov_facilities/va_gov_facilities.post_update.php|128 col 5| Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
docroot/modules/custom/va_gov_facilities/va_gov_facilities.post_update.php|132 col 5| Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
docroot/modules/custom/va_gov_facilities/va_gov_facilities.post_update.php|138 col 1| Missing function doc comment
docroot/modules/custom/va_gov_facilities/va_gov_facilities.post_update.php|142 col 5| Inline comments must start with a capital letter
docroot/modules/custom/va_gov_facilities/va_gov_facilities.post_update.php|142 col 5| Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
| return "Processing health service nodes...{$sandbox['current']} / {$sandbox['total']}"; | ||
| } | ||
|
|
||
| function _migrate_address(){ |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.Commenting.FunctionComment.Missing> reported by reviewdog 🐶
Missing function doc comment
| return "Processing health service nodes...{$sandbox['current']} / {$sandbox['total']}"; | ||
| } | ||
|
|
||
| function _migrate_address(){ |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Generic.Functions.OpeningFunctionBraceKernighanRitchie.SpaceBeforeBrace> reported by reviewdog 🐶
Expected 1 space before opening brace; found 0
docroot/modules/custom/va_gov_facilities/va_gov_facilities.post_update.php
Outdated
Show resolved
Hide resolved
docroot/modules/custom/va_gov_facilities/va_gov_facilities.post_update.php
Outdated
Show resolved
Hide resolved
docroot/modules/custom/va_gov_facilities/va_gov_facilities.post_update.php
Outdated
Show resolved
Hide resolved
| // Moving to: service_location ->field_email_contacts. | ||
| } | ||
|
|
||
| function _migrate_hours() { |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.WhiteSpace.ScopeIndent.IncorrectExact> reported by reviewdog 🐶
Line indented incorrectly; expected 0 spaces, found 2
| // Moving to: service_location ->field_email_contacts. | ||
| } | ||
|
|
||
| function _migrate_hours() { |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.Commenting.FunctionComment.Missing> reported by reviewdog 🐶
Missing function doc comment
| } | ||
|
|
||
| function _migrate_hours() { | ||
| // Moving from: |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.WhiteSpace.ScopeIndent.IncorrectExact> reported by reviewdog 🐶
Line indented incorrectly; expected 2 spaces, found 4
|
|
||
| function _migrate_hours() { | ||
| // Moving from: | ||
| // Moving to: service_location ->field_office_hours (Office hours field). |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.WhiteSpace.ScopeIndent.IncorrectExact> reported by reviewdog 🐶
Line indented incorrectly; expected 2 spaces, found 4
| function _migrate_hours() { | ||
| // Moving from: | ||
| // Moving to: service_location ->field_office_hours (Office hours field). | ||
| // and: service_location ->field_hours (list). |
There was a problem hiding this comment.
🚫 [PHP_CodeSniffer] <Drupal.WhiteSpace.ScopeIndent.IncorrectExact> reported by reviewdog 🐶
Line indented incorrectly; expected 2 spaces, found 4
swirtSJW
force-pushed
the
VACMS-16959-work-with-us-menu-lock
branch
from
a5146f0 to
62d9839
Compare
Description
Relates to #issueid. (or closes?)
Testing done
Screenshots
QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
As user uid with user_role
Definition of Done
Select Team for PR review
CMS TeamPublic websitesFacilitiesUser supportAccelerated PublishingIs this PR blocked by another PR?
DO NOT MERGEDoes this PR need review from a Product Owner
Needs PO reviewCMS user-facing announcement
Is an announcement needed to let editors know of this change?