Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16853: next-build git information for content release #16923

Closed
wants to merge 18 commits into from

Conversation

alexfinnarn
Copy link
Contributor

@alexfinnarn alexfinnarn commented Jan 19, 2024

Description

closes #16853

Testing done

Manually on my local machine and also Tugboat using the QA steps provided below.

Screenshots

Screenshot 2024-01-22 at 4 31 00 PM

QA steps

  1. Make sure the next-build repo is cloned into the right place. Should be done with composer va:next:install
  2. Make sure the GITHUB_TOKEN environmental variable is set with a valid token.
  3. Log into the CMS and go to /admin/content/deploy/next_git
    • Confirm next-build is in the first form radio instead of content-build
  4. Select the "Select a different next-build branch/pull request - for example, to see your content in a newer frontend design." radio on the first radio group.
  5. Look for some PRs on https://github.com/department-of-veterans-affairs/next-build/pulls
  6. Type the first couple words of each PR into the autocomplete box
    • Confirm PR 1 shows up and can be selected
    • Confirm PR 2 shows up and can be selected

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been updated if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 19, 2024 21:04 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 19, 2024 21:25 Destroyed
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 20, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 20, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 20, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 20, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 20, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 20, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 20, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 20, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 21, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 21, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 21, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 21, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 21, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 21, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 21, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 21, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 22, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 22, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 22, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 22, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 22, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 22, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 31, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 31, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 31, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 31, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 1, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 1, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 1, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 1, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 1, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 1, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 1, 2024 15:58 Destroyed
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 1, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 1, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 2, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 2, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 2, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 2, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 2, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Feb 2, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 5, 2024 18:10 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 5, 2024 18:11 Destroyed
* @param \Drupal\Component\Datetime\TimeInterface $time
* The site time service.
*/
public function __construct(StateInterface $state, EventDispatcherInterface $dispatcher, TimeInterface $time) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [PHP_CodeSniffer] <Generic.CodeAnalysis.UselessOverridingMethod.Found> reported by reviewdog 🐶
Possible useless method overriding detected

@va-cms-bot va-cms-bot temporarily deployed to Tugboat February 6, 2024 14:52 Destroyed
@alexfinnarn alexfinnarn deleted the VACMS-16853-next-build-branches branch February 22, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accelerated Publishing CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next Build and Vets Website branches can be chosen on Tugboat
2 participants