Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16348: Add appointment fields service location #16907

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Jan 18, 2024

Description

Relates to #16348

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

* VACMS:14704: Adding service modalities

* VACMS-14704: Adds vocabulary

* VACMS-14704: Adds free-text fields.

* VACMS-14704: Update langage around service delivery

* VACMS-14704: Updates taxonomy label and description
@omahane omahane force-pushed the VACMS-16348-add-appointment-fields-service-location branch 2 times, most recently from 2cf4175 to 3449fe9 Compare January 18, 2024 23:26
@omahane omahane requested a review from a team as a code owner January 18, 2024 23:26
@omahane omahane force-pushed the VACMS-16348-add-appointment-fields-service-location branch from 129025b to 8ca06be Compare January 23, 2024 13:25
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 23, 2024 16:43 Destroyed
* VACMS:14704: Adding service modalities

* VACMS-14704: Adds vocabulary

* VACMS-14704: Adds free-text fields.

* VACMS-14704: Update langage around service delivery

* VACMS-14704: Updates taxonomy label and description
* VACMS:14704: Adding service modalities

* VACMS-14704: Adds vocabulary

* VACMS-14704: Adds free-text fields.

* VACMS-14704: Update langage around service delivery

* VACMS-14704: Updates taxonomy label and description
@omahane omahane force-pushed the VACMS-16348-add-appointment-fields-service-location branch from cf8974c to b96e511 Compare January 24, 2024 15:11
@omahane omahane requested review from a team as code owners January 24, 2024 15:11
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 24, 2024 15:23 Destroyed
@swirtSJW swirtSJW force-pushed the integration-service-location branch from d5fa239 to bab50cc Compare January 29, 2024 20:41
@omahane omahane closed this Jan 30, 2024
@omahane omahane deleted the VACMS-16348-add-appointment-fields-service-location branch February 16, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants