VACMS-16882: Resolves Error: Call to a member function getValue() on null

[dsasser]

Description

Resolves a bug in addToNationalOutreachCalendar() which can cause a php error.

Relates to #16882

Testing done

Tested using different user roles, and using new and existing Event nodes.

QA steps

As a content admin

1. Visit /node/add/event
2. Fill out the required fields
3. In the right sidebar, under "Feature This Content", check the "Featured" checkbox
4. Save the node
   • Validate that there are no errors

Definition of Done

• Documentation has been updated, if applicable.
• Tests have been added if necessary.
• Automated tests have passed.
• Code Quality Tests have passed.
• Acceptance Criteria in related issue are met.
• Manual Code Review Approved.
• If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

• CMS Team
• Public websites
• Facilities
• User support
• Accelerated Publishing

[github-actions]

GitHub Workflows (.github/workflows/*.yml)

Have you...

• pinned all affected GitHub Actions at a specific commit by SHA?
• reviewed the source code of the action at the commit you are pinning?
• confirmed that no GitHub security measures are being bypassed?
• checked for any injection of user content into protected contexts?
• reviewed Security hardening for GitHub Actions?
• reviewed GitHub Workflows?

[ndouglas]

Rebuilding because of Tugboat antics.

[va-cms-bot]

va/tests/status-error:

entity_update

Title    �[31mEntity/field definitions�[39m

Severity �[31mError�[39m

�[31mValue    �[39m�[31mMismatched entity and/or field definitions�[39m�[31m �[39m

�[31m         �[39m                                           

[Becapa]

Looks good. I was able to save the node:

[edmund-dunn]

Worked as expected. No errors! Nice work!!

[swirtSJW]

Just one question from me.

[swirtSJW]

Looks like a good combination to defend against NULL.

[swirtSJW]

I am pretty sure I am missing the use case/edge case here so apologies for the potentially dumb question here.

Is there an edge case where it would get past line 49 and still not have a 'value' here at line 53? If there is, it might be good to spell out with a comment the situation that would lead to the assertion failing.

[dsasser]

Good question Steve. My thinking in this case was that there is actually no guarantee that, even though the field has a value, that the property 'value' exists in the returned array. For entity reference fields for example, the primary field property is 'target_id'. So this assertion was a way for me to protect against any future changes to the target field where it changes to a different type, or for some reason the 'value' property changes to something else.

Generally I've been trying to get away from using magic methods to get to field values, which would actually improve the readability of this code, but this is the outcome of doing that in this situation.

[swirtSJW]

Makes sense. Thanks for the explanation @dsasser.