Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16289 bump next-build preview secret timer #16839

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

tjheffner
Copy link
Contributor

@tjheffner tjheffner commented Jan 12, 2024

Description

Closes #16289. Updates the secret timer to 1 day. This is a low-lift change given that preview secret is required by next-drupal at this time.

Testing done

  • on this tugboat environment, enabled the NEXT_STORY_PREVIEW feature flag
  • visited a story node and clicked the "preview button"
  • 503 because next-drupal hadn't started yet
  • waited until build completed
  • clicked the preview button again, page resolve
  • wait 10 minutes
  • clicked the preview button again, page resolve

QA steps

visit any story node, preview it
come back in 6 minutes (longer than the old 5 minute timer)
hit the preview button again without refreshing the page (which would have generated a new secret before)
preview link should still resolve

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 12, 2024 22:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 12, 2024 23:40 Destroyed
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 13, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 13, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 13, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 13, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 13, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 13, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 13, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 13, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 14, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 14, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 14, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 14, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 14, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 14, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 14, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 14, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 15, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 15, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 15, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 15, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 15, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 15, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 15, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 15, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 16, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 16, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 22, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 22, 2024 23:06 Destroyed
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 23, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 23, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 23, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 23, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 23, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 23, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 23, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 23, 2024
@tjheffner
Copy link
Contributor Author

Noting the failed tugboat rebuild check is a false report here. The environment is built and works for testing.

@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 24, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 24, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 24, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 24, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 24, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 24, 2024
@va-cms-bot va-cms-bot added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 24, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 24, 2024
@tjheffner tjheffner enabled auto-merge (squash) January 24, 2024 20:16
@tjheffner tjheffner disabled auto-merge January 24, 2024 20:18
@tjheffner tjheffner merged commit 3a59e67 into main Jan 24, 2024
14 of 19 checks passed
@tjheffner tjheffner deleted the VACMS-16289-preview-secret-timer branch January 24, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMS Editors should not see error messages due to CMS Preview secrets expiring
5 participants