-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-16575: Add extra validation to allow for combination of reusable and single page QAs. #16838
Merged
dsasser
merged 9 commits into
main
from
VACMS-16575-unable-to-save-clp-with-only-reusable-q
Jan 16, 2024
Merged
VACMS-16575: Add extra validation to allow for combination of reusable and single page QAs. #16838
dsasser
merged 9 commits into
main
from
VACMS-16575-unable-to-save-clp-with-only-reusable-q
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 13, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 13, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 13, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 13, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 14, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 14, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 14, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 14, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 15, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 15, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 15, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 15, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 16, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 16, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 16, 2024
Becapa
commented
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unable to approve the changes, but the QA steps all pass and the code looks good to me.
dsasser
approved these changes
Jan 16, 2024
dsasser
deleted the
VACMS-16575-unable-to-save-clp-with-only-reusable-q
branch
January 16, 2024 17:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #16575 .
Testing done
Screenshots
QA steps
As a user with content_admin role
Definition of Done
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing
Is this PR blocked by another PR?
DO NOT MERGE
Does this PR need review from a Product Owner
Needs PO review
CMS user-facing announcement
Is an announcement needed to let editors know of this change?