Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16545: Patch smart_date recurring date validation. #16826

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

Becapa
Copy link
Contributor

@Becapa Becapa commented Jan 11, 2024

Description

Closes #16545 .

QA steps

As a user that can create/edit events

  1. Create or edit an event and fill in all required fields.
    • Validate that the event can be saved when the Make recurring checkbox is checked and the Until date comes after the Start date.
  2. Edit the event again (or create another new event)
    • Validate that the event shows an error upon saving when the Until date comes before the Start date.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@Becapa Becapa requested a review from dsasser January 11, 2024 20:12
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2024 20:12 Destroyed
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 12, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 12, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 12, 2024
dsasser
dsasser previously approved these changes Jan 16, 2024
Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Screenshot 2024-01-16 at 9 00 21 AM

Copy link
Contributor

@jilladams jilladams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daniel previously approved; merging main back in un-approved but no other code changes were made. So: I'm rubber stamping to unblock since Daniel's now without power. If that doesn't work, it'll roll to tomorrow and that's ok.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 16, 2024 21:54 Destroyed
@Becapa Becapa merged commit 4563cbf into main Jan 16, 2024
18 of 19 checks passed
@Becapa Becapa deleted the VACMS-16545-invalid-event-date-bug branch January 16, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refresh-tugboat-cache Used by GHA Tugboat automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Possible to create an Event with an invalid date, fails content-build
5 participants