-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update character count status message on "Centralized content" content type - purpose field #16807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmpickett
added
CMS design
CMS design system
Facilities
Facilities products (VAMC, Vet Center, etc)
labels
Jan 10, 2024
davidmpickett
changed the title
Centralized content - purpose - character count - status message
Update character count status message on "Centralized content" content type - purpose field
Jan 10, 2024
davidmpickett
added
the
Drupal Site Building
For tasks that involve updating Drupal config, but don't involve significant coding
label
Jan 10, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 11, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 11, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 11, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 11, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 12, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 12, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 12, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 12, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 16, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 16, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 16, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 17, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 17, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 17, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 17, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 18, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 18, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 18, 2024
github-actions
bot
removed
the
refresh-tugboat-cache
Used by GHA Tugboat automation
label
Jan 18, 2024
swirtSJW
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine and it tests out
@davidmpickett I did notice that we lost a change of color approaching and going past the limit. Was this intended?
Existing color change example.
Related slack conversation about the loss of color |
6 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CMS design system
CMS design
Drupal Site Building
For tasks that involve updating Drupal config, but don't involve significant coding
Facilities
Facilities products (VAMC, Vet Center, etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #16659.
#16659 provides new guidance on how the status message on character count status messages should be worded. This PR would update wording on the Content Type: Centralized Content.
This came out of feedback from the VBA Regional Office CMS collab cycle.
The Facilities team is the primary user of Centralized Content, so may not need review from other teams?
Testing done
Confirmed on Tugboat
Screenshots
QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
As a Drupal Admin (e.g. [email protected])
Definition of Done