Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16522: Move VAMC System pages to restricted_archive workflow #16779

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Jan 9, 2024

Description

Relates to #16522

Testing done

Manually

Screenshots

Example page (VAMC System VA Police page)

In production

Screenshot 2024-01-09 at 12 18 03 PM

In the PR environment

Screenshot 2024-01-09 at 12 18 35 PM

QA steps

What needs to be checked to prove this works?

  • Log in as an admin
  • Assign QA Content Publisher to the "VA Boston health care" section
  • Assign QA Content Publisher to the "VA Nebraska-Western Iowa health care" section
  • Assign test_Cordie.Kuhn13 to the "Content admin" role

Try to archive VAMC System VA Police page as an editor

Try to edit an archived node as an editor

  • As QA Content Publisher
  • Go to the archived Policies page in VA Nebraska-Western Iowa health care
  • Confirm that you cannot edit the page

What needs to be checked to prove it didn't break any related things?

Try to archive VAMC System VA Police page as a content admin

Try to edit an archived node as an as a content admin

  • As test_Cordie.Kuhn13
  • Go to the archived Policies page in VA Nebraska-Western Iowa health care
  • Confirm that you can edit the page

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@omahane omahane requested review from a team as code owners January 9, 2024 17:38
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 9, 2024 17:38 Destroyed
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 9, 2024
@github-actions github-actions bot added Facilities Facilities products (VAMC, Vet Center, etc) and removed refresh-tugboat-cache Used by GHA Tugboat automation labels Jan 9, 2024
@omahane omahane requested a review from swirtSJW January 9, 2024 19:18
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great and results in QA passing.

Also update hook output is as expected
image

@omahane omahane enabled auto-merge (squash) January 10, 2024 15:01
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 10, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@JunTaoLuo JunTaoLuo added the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@github-actions github-actions bot removed the refresh-tugboat-cache Used by GHA Tugboat automation label Jan 11, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 11, 2024 18:16 Destroyed
@omahane omahane merged commit 09f51dc into main Jan 11, 2024
19 checks passed
@omahane omahane deleted the VACMS-16522-move-non-facility-pages-restricted-archive branch January 11, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants